-
Notifications
You must be signed in to change notification settings - Fork 497
Revert "Update Stealc.yar" #2677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 0cecf1e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kevoreilly, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request reverts a previous update to the Stealc.yar
YARA rule. The primary purpose is to remove the dependency on the pe
module and specific import checks (tier0.dll
and msdart.dll
) from the Stealc
rule's condition, effectively simplifying the rule and making it less restrictive regarding PE imports.
Highlights
- YARA Rule Modification: The
Stealc
YARA rule has been modified to remove theimport "pe"
statement and the conditionnot (pe.imports("tier0.dll") or pe.imports("msdart.dll"))
. This simplifies the rule's logic by removing checks for specific PE imports.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous change to the Stealc.yar
YARA rule. The revert removes the dependency on the pe
module and a condition checking for specific DLL imports. This simplifies the rule and makes it consistent with the StealcV2
rule in the same file. The change appears correct and likely addresses issues introduced by the reverted commit. I have added one suggestion to improve the rule's condition to enhance performance and reduce potential false positives, which aligns with the likely intent of the original change.
uint16(0) == 0x5A4D | ||
and not (pe.imports("tier0.dll") or pe.imports("msdart.dll")) | ||
and any of them | ||
uint16(0) == 0x5A4D and any of them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reverting the pe.imports
check is likely necessary, the rule could be made more efficient and less prone to false positives on very large files by adding a filesize
check. This is a common practice in YARA rules to constrain their scope and improve performance.
uint16(0) == 0x5A4D and filesize < 1000KB and any of them
Reverts #2674