Pybind11 2.3 adaptions #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phispilger
force-pushed
the
pybind11_2_3
branch
from
6c4da3c to
9334159
Compare
* fix some broken (for pybind11 2.3) tests Change-Id: Ieac1cda53c7ff94b458e70e0f85d079819e1d262
phispilger
force-pushed
the
pybind11_2_3
branch
from
9334159 to
98dbebe
Compare
Owner
|
Thanks, this addresses one of the points in #20. Before we merge this let's also find out what the intended behavior w.r.t. the comparison operators is. 👍 IIRC The corresponding tests are still present there? Also you mentioned that you found a related issue / PR in the pybind11 project? I also intend to go through the other changes of 2.3 and decide where we need to make adjustments, as mentioned in #20. |
kljohann
requested changes
Dec 12, 2019
Owner
kljohann
left a comment
kljohann
left a comment
There was a problem hiding this comment.
Can you also adjust .circleci/config.yml to use the latest 2.3 tag / branch of pybind11?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.