#7 Adds sorting functionality for connections statistics#26
Open
gintsgints wants to merge 2 commits intomainfrom
Open
#7 Adds sorting functionality for connections statistics#26gintsgints wants to merge 2 commits intomainfrom
gintsgints wants to merge 2 commits intomainfrom
Conversation
kmoppel
reviewed
Feb 22, 2026
| println!(" {count:>6} {appname}"); | ||
| let mut entries: Vec<_> = self.connection_attempts_by_time_bucket.iter().collect(); | ||
| entries.sort_by(|a, b| b.1.cmp(a.1)); | ||
| for (bucket, count) in entries { |
Owner
There was a problem hiding this comment.
"Connections by time bucket:" would need some kind of "top" limit still not to overflow the viewport for large logfiles (20 time slots maybe?). Looks good otherwise! @gintsgints
Collaborator
Author
There was a problem hiding this comment.
I imagine three options here:
- leave this to user to pipe output to more
- implement option --limit for top command
- rework this to be TUI application (like TOP :) )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.