Translate N3ME, resolution based on screen size #221

xGuTeK · 2024-05-17T13:28:46Z

No description provided.

twostars · 2024-05-17T13:58:09Z

src/tool/N3ME/DlgBase.cpp

            } else if (pItem->m_propName == "Far Plane") {
                pC->m_Data.fFP = (float)atof(pItem->m_curValue);
-            } else if (pItem->m_propName == "안개 사용") {
+            } else if (pItem->m_propName == "Use fog") {


The case here is inconsistent to what you set the properties to.
You called them "use fog", and "fog color" and then you're checking against "Use fog" & "Fog color" -- which won't match because of case sensitivity.

Good catch! I also addressed similar places using with breaking changes in terms of properties.

twostars · 2024-05-17T14:04:13Z

src/tool/N3ME/MapMng.cpp

        return;
    }
-    char  comment[80] = {"이파일 여는 사람 바보..^^"};
+    char  comment[80] = {"The person who opens this file is an idiot...^^"};


I'm not sure if it's wise to translate this one, considering it's used directly in the files themselves. Though it's technically not checked, and still remains within the constraint, it does technically change the file formats unofficially. Whether or not that's a concern with this project, I don't know.

@twostars has a point, however from my end this is fine, as this file has no logic nor used officially to check its content. In Korean it looks like random bytes, so at least in English we'll see the actual content lol

twostars · 2024-05-17T14:07:12Z

src/tool/N3ME/SoundMgr.cpp

-// list의 sort함수 베꼈당..-.-
-// 제대로 동작 안하더라..ㅠ.ㅠ
+// Copied the sort function of the list..
+// It didnt work properly..


Seems the apostrophe is broken here

stevewgr

Hi @xGuTeK, thanks for the PR!
Note that I didn't review all of it, since I think there are already enough comments in here to address before we move further with the review.
Let me know if you need any help.

stevewgr · 2024-05-17T23:21:25Z

src/tool/N3ME/DTexGroup.cpp

-        //리스트 돌면서 DTexIndx와 같은거 나오면 다 없애버려...
+        //Go through the list and if something like DTexIndx comes up, get rid of it...
        it = m_Attributes[i].begin();
        while (it != m_Attributes[i].end()) {
            DTEXTILEATTR * pTile = *it;
            if (pTile->TexID == DTexID) {
-                //지우자...
+                //Let's erase...


I don't know if these were auto translated, but normally we should add two spaces after a comment operator:
// my comment

The same should apply for all other comments, at least the ones that are not aligned.

stevewgr · 2024-05-17T23:28:08Z

src/tool/N3ME/DlgSetDTex.cpp

 ON_BN_CLICKED(IDC_BTN_SAVE_TILESET, OnBtnSaveTileset)
 ON_BN_CLICKED(IDC_BTN_LOAD_TILESET, OnBtnLoadTileset)
 //}}AFX_MSG_MAP
+ON_STN_CLICKED(IDC_STATIC_TILESETNAME, &CDlgSetDTex::OnStnClickedStaticTilesetname)


Was this added by accident? If not used, let's delete.

stevewgr · 2024-05-17T23:28:20Z

src/tool/N3ME/DlgSetDTex.cpp

+
+void CDlgSetDTex::OnStnClickedStaticTilesetname() {
+    // TODO: Add your control notification handler code here
+}


Was this added by accident? If not used, let's delete.

stevewgr · 2024-05-17T23:28:27Z

src/tool/N3ME/DlgSetDTex.h

+
+  public:
+    afx_msg void OnStnClickedStaticTilesetname();


Was this added by accident? If not used, let's delete.

stevewgr · 2024-05-17T23:30:29Z

src/tool/N3ME/DTexGroupMng.cpp

    wsprintf(pGroup->m_Name, pName);

-    //새로운 idx를 지정하기 위해서 일단 정렬을 하자..
+    //Let’s sort first to specify a new idx.


Same comment as here: #221 (comment)

stevewgr · 2024-05-18T00:05:53Z

src/tool/N3ME/MapMng.cpp

-        m_pSceneOutput->CameraGetActive()->m_Data.fNP = 1.0f;
-        m_pSceneOutput->CameraGetActive()->m_Data.fFP = m_pMainFrm->GetFP();
+        /*
+        m_pSceneOutput->CameraGetActive()->m_Data.fNP = 1.0f; //gutek
+        m_pSceneOutput->CameraGetActive()->m_Data.fFP = m_pMainFrm->GetFP(); //gutek
+        */


Any reason for commenting this one out? 🚨

stevewgr · 2024-05-18T00:11:03Z

src/tool/N3ME/MapMng.cpp

+    //    if(true == m_pSceneOutput->CheckOverlappedShapesAndReport()) //Check for name or location duplicates...
    //    {
-    //        int idYesNo = ::MessageBox(::GetActiveWindow(), "중복된 오브젝트들을 삭제 하시겠습니까?", "중복된 오브젝트 처리", MB_YESNO);
+    //        int idYesNo = ::MessageBox(::GetActiveWindow(), "Do you want to delete duplicate objects?", "Handling duplicate objects", MB_YESNO);


duplicated

stevewgr · 2024-05-18T00:16:25Z

src/tool/N3ME/N3ME.cpp

+  public:
+    afx_msg void OnBnClickedOk();


Remove unused.

Suggested change

public:

afx_msg void OnBnClickedOk();

stevewgr · 2024-05-18T00:16:35Z

src/tool/N3ME/N3ME.cpp

 //{{AFX_MSG_MAP(CAboutDlg)
 // No message handlers
 //}}AFX_MSG_MAP
+ON_BN_CLICKED(IDOK, &CAboutDlg::OnBnClickedOk)


Suggested change

ON_BN_CLICKED(IDOK, &CAboutDlg::OnBnClickedOk)

stevewgr · 2024-05-18T00:16:45Z

src/tool/N3ME/N3ME.cpp

+
+void CAboutDlg::OnBnClickedOk() {
+    // TODO: Add your control notification handler code here
+    CDialog::OnOK();
+}


Suggested change

void CAboutDlg::OnBnClickedOk() {

// TODO: Add your control notification handler code here

CDialog::OnOK();

}

xGuTeK added 2 commits May 17, 2024 13:59

Translate N3ME

8d8f6f9

Change render resolution based on screen size

90f6476

twostars reviewed May 17, 2024

View reviewed changes

stevewgr requested changes May 18, 2024

View reviewed changes

stevewgr marked this pull request as draft May 23, 2024 05:43

stevewgr assigned xGuTeK Aug 9, 2024

Translate N3ME, resolution based on screen size #221

Are you sure you want to change the base?

Translate N3ME, resolution based on screen size #221

Uh oh!

Conversation

xGuTeK commented May 17, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevewgr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!