Skip to content

Fix autoreport labels for NumField #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix autoreport labels for NumField #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f37c74
fix autoreport
joshuaberetta Jul 7, 2021
d5e69e3
fix breaking tests
joshuaberetta Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/formpack/schema/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,8 +507,9 @@ def get_disaggregated_stats(self, metrics, top_splitters,
for val, counter in metrics.items():
if val is None:
continue
for splitter, count in counter.items():
inversed_metrics[splitter].extend([val] * count)
for splitter, trans in top_splitters:
count = counter.pop(splitter, 0)
inversed_metrics[trans].extend([val] * count)

for splitter, values in inversed_metrics.items():

Expand Down
20 changes: 10 additions & 10 deletions tests/test_autoreport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,24 +436,24 @@ def test_disaggregate(self):
'stdev': 0.7071067811865476
}
),
(
'2002-01-01',
{
'mean': 2,
'median': 2.0,
'mode': 2,
'stdev': 0.0
}
),
(
'2003-01-01',
{
'mean': 1.0,
'mean': 1,
'median': 1,
'mode': '*',
'stdev': '*'
}
),
(
'2002-01-01',
{
'mean': 2.0,
'median': 2.0,
'mode': 2,
'stdev': 0.0
}
)
)
}
)
Expand Down