fix(assetUsage): migrate asset usage table DEV-1013 #6269
Conversation
…dev-1013-mirgrate-to-universal-table
|
@duvld you forgot to add task id in PR title :) |
duvld
changed the title
|
Let's give the table a set height so the sort dropdowns don't get cut off if you only have one asset like here: This would also make it so the table doesn't jump sizes when you switch from a page of 10 results to a page of 1 result, for example. Also, there is currently some horizontal overflow, seemingly no matter how wide my screen is. It's fine if there is horizontal overflow on small screens, but can you fix the column sizes so there is no overflow on normal screens? |
| errorMessageDisplay: t('There was an error fetching asset usage data.'), | ||
| }) | ||
| return { | ||
| status: 200 as const, |
There was a problem hiding this comment.
What's the story here? Pre-defining the response status seems strange.
| const queryResult = useQuery({ | ||
| queryKey: [QueryKeys.assetUsage, pagination.limit, pagination.offset, orgQuery.data, orgQuery.data?.id, order], | ||
| queryFn: () => getOrgAssetUsage(pagination.limit, pagination.offset, orgQuery.data ? orgQuery.data.id : '', order), | ||
| placeholderData: keepPreviousData, | ||
| }) |
There was a problem hiding this comment.
good to migrate to custom react-queries 👌 But let's migrate straight Orval's react-query!
See useOrganizationsServiceUsageRetrieve, or useOrganizationsServiceUsageSummary that just got merged into main. Afterwards the whole of assetUsage.api.ts could be deleted.
P.S. #6307 also uses Orval's react-query response in UniversalTable
| errorMessageDisplay: t('There was an error fetching asset usage data.'), | ||
| }) | ||
| return { | ||
| status: 200 as const, |
🗒️ Checklist
<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflow📣 Summary
Use the new table component to display asset usage data. Fixes old pagination issues
💭 Notes
Modeled after how access logs uses the universal table. Removes
uidfrom theAssetWithUsagetype as it is not actually expected as a response from backend--updated logic accordingly👀 Preview steps