Implement polls #933

DRSchlaubi · 2024-04-09T19:50:45Z

No description provided.

Moortu · 2024-08-18T04:44:55Z

Would love to see this feature merged after a review, conflicts resolved and fixes

lukellmann · 2024-08-19T20:29:26Z

Would love to see this feature merged after a review, conflicts resolved and fixes

i can take a look, but i'll be on vacation for a week first

Moortu · 2024-08-19T20:31:22Z

Would love to see this feature merged after a review, conflicts resolved and fixes

i can take a look, but i'll be on vacation for a week first

Small world, I'm on vacation rn for a week

Have a good week.
And I look forward to this feature.

I can upgrade my bot in a significant way with it.

Currently this is only partial and we might add something like a PollMessage or Poll class to core

DRSchlaubi · 2024-08-25T11:11:55Z

Now ready

They seem to be here by accident, I already removed them for good in #944.

All other kord enums use camel case naming.

lukellmann

also missing Permission.SendPolls, Intent.GuildMessagePolls, Intent.DirectMessagePolls

lukellmann · 2024-09-02T22:46:27Z

common/src/commonMain/kotlin/entity/Interactions.kt

    val values: Optional<List<String>> = Optional.Missing(),
-    val components: Optional<List<DiscordComponent>> = Optional.Missing()
+    val components: Optional<List<DiscordComponent>> = Optional.Missing(),
+    val poll: Optional<DiscordPoll> = Optional.Missing()


Suggested change

val poll: Optional<DiscordPoll> = Optional.Missing()

InteractionCallbackData models https://discord.com/developers/docs/interactions/receiving-and-responding#interaction-object-interaction-data, there is no poll object there (it would be included in DiscordInteraction.message (for components on a poll message, if supported at some point) or InteractionCallbackData.resolved.messages (for message commands etc.) instead)

lukellmann · 2024-09-02T23:00:32Z

core/src/commonMain/kotlin/behavior/MessageBehavior.kt

+/**
+ * Behavior of a Poll message.
+ */
+public interface PollBehavior : MessageBehavior {


i don't think it's a good idea to have Poll/PollBehavior extend Message/MessageBehavior - a poll is part of a message, not a message itself; it doesn't have a message type; ...

I am quite sure poll message can't contain anything but the poll

that might be true for now, but who knows about the future. conceptually a poll is part of a message.

lukellmann · 2024-09-02T23:07:49Z

core/src/commonMain/kotlin/behavior/channel/PollParentChannelBehavior.kt

+/**
+ * Requests to create a poll.
+ *
+ * @throws [RestRequestException] if something went wrong during the request.
+ */
+@OptIn(KordUnsafe::class)
+public suspend inline fun PollParentChannelBehavior.createPoll(block: PollBuilder.() -> Unit): Poll {
+    contract {
+        callsInPlace(block, InvocationKind.EXACTLY_ONCE)
+    }
+
+    return createMessage { poll(block) } as Poll
+}


do we need this function?

#933 (comment)

also iirc the poll function is unsafe, also this returns a poll object

also iirc the poll function is unsafe, also this returns a poll object

see my other comment about that annotation

lukellmann · 2024-09-02T23:09:56Z

core/src/commonMain/kotlin/behavior/channel/PollParentChannelBehavior.kt

+ *
+ * @see createPoll
+ */
+public interface PollParentChannelBehavior : MessageChannelBehavior


are there MessageChannelBehaviors that can't have polls? or what is the reason for this interface?

announcement channels, I think, not sure but there was one

i can create one in an announcement channel, that can't be it

i've checked again i can create polls in all types of channels that would be a MessageChannelBehavior in kord: GUILD_TEXT, DM, GUILD_VOICE, GROUP_DM, GUILD_ANNOUNCEMENT, ANNOUNCEMENT_THREAD, PUBLIC_THREAD, PRIVATE_THREAD, GUILD_STAGE_VOICE

@gdude2002 what channel did you say it wouldn't work in

News channels, but it seems they've fixed it now.

lukellmann · 2024-09-02T23:12:13Z

common/src/commonMain/kotlin/entity/DiscordMessage.kt

    val thread: Optional<DiscordChannel> = Optional.Missing(),
-    val position: OptionalInt = OptionalInt.Missing
+    val position: OptionalInt = OptionalInt.Missing,
+    val poll: Optional<DiscordPoll> = Optional.Missing()


should also be added to DiscordPartialMessage to be safe

lukellmann · 2024-09-03T00:51:59Z

rest/src/commonMain/kotlin/builder/message/PollBuilder.kt

+
+    override fun toRequest(): CreatablePoll = CreatablePoll(
+        question ?: error("Please set a question"),
+        answers,


Suggested change

answers,

answers.toList(),

defensive copy

lukellmann · 2024-09-03T00:55:21Z

rest/src/commonMain/kotlin/builder/message/PollBuilder.kt

+    public fun answer(title: String, emojiUnicode: String? = null, id: Int = answers.size) {
+        require(answers.size < 10) { "Cannot add more than 10 answers" }
+        answers.add(
+            DiscordPoll.Answer(
+                answerId = id,
+                pollMedia = DiscordPoll.Media(
+                    Optional(title),
+                    Optional(emojiUnicode?.let { DiscordPartialEmoji(name = it) }).coerceToMissing()
+                )
+            )
+        )
+    }
+
+    /**
+     * Adds an answer with [title] and [emoji].
+     *
+     * @param id the answer id
+     */
+    public fun answer(title: String, emoji: Snowflake? = null, id: Int = answers.size) {
+        require(answers.size < 10) { "Cannot add more than 10 answers" }
+        answers.add(
+            DiscordPoll.Answer(
+                answerId = id,
+                pollMedia = DiscordPoll.Media(
+                    Optional(title),
+                    Optional(emoji?.let { DiscordPartialEmoji(id = it) }).coerceToMissing()
+                )
+            )
+        )
+    }


is the id required to be sent? that is is the answer_id field optional on poll creation? this makes me think it might be:

Only sent as part of responses from Discord's API/Gateway.

lukellmann · 2024-09-03T01:05:16Z

rest/src/commonMain/kotlin/builder/message/PollBuilder.kt

+     *
+     * @param id the answer id
+     */
+    public fun answer(title: String, emojiUnicode: String? = null, id: Int = answers.size) {


could emoji be used for the parameter name instead?

lukellmann · 2024-09-03T01:07:29Z

gateway/src/commonMain/kotlin/Event.kt

+                "MESSAGE_POLL_VOTE_ADD" -> MessagePollVoteAdd(decode(MessagePollEventData.serializer()), sequence)
+                "MESSAGE_POLL_VOTE_REMOVE" -> MessagePollVoteRemove(decode(MessagePollEventData.serializer()), sequence)


i'd keep these above the deprecated events

lukellmann · 2024-09-03T01:15:08Z

gateway/src/commonMain/kotlin/Event.kt

+public data class MessagePollVoteAdd(val data: MessagePollEventData, override val sequence: Int?) : DispatchEvent()
+public data class MessagePollVoteRemove(val data: MessagePollEventData, override val sequence: Int?) : DispatchEvent()


these should also be exposed in core

lukellmann · 2024-09-06T19:50:45Z

also relevant: discord/discord-api-docs#7090

lukellmann · 2024-09-07T20:51:15Z

also discord/discord-api-docs#7050

Moortu · 2024-12-10T21:24:55Z

Any progress?

lukellmann · 2024-12-20T01:33:37Z

Any progress?

@DRSchlaubi?

DRSchlaubi · 2024-12-20T01:34:41Z

Actually we said that you wanted to finish this haha

lukellmann · 2024-12-20T01:36:12Z

Actually we said that you wanted to finish this haha

Oh, yeah I forgot about that and have been busy otherwise 😅

DRSchlaubi requested a review from lukellmann April 9, 2024 19:50

yuuahp mentioned this pull request Jun 3, 2024

投票機能(Poll)をサポートする jaoafa/VCSpeaker.kt#137

Open

DRSchlaubi added 17 commits August 25, 2024 12:46

Add Poll entities

61a3c94

Add poll to create request

18ddf0b

Add builders

3ee35ec

Api Dump

57d4957

Add error codes

9ea2746

Add routes

23e450a

Add events

8a1b62f

Add polls to core

eea7cc3

Currently this is only partial and we might add something like a PollMessage or Poll class to core

Make results nullable

303c792

Api dump

e09b4d7

Add PollParentChannelBehavior

5c394c4

Fix warning

5099335

Add subclasses for Message

25053f4

Api dump

5f32764

Fix unsafe api usage

a883c08

Fix test

987969b

Make expiry nullable

65a578f

Add PollBehavior

2a306cd

DRSchlaubi force-pushed the feature/polls branch from 13b3d10 to 2a306cd Compare August 25, 2024 11:12

DRSchlaubi and others added 5 commits August 25, 2024 13:24

No longer require expires

274cf12

Remove deprecated functions

164203b

They seem to be here by accident, I already removed them for good in #944.

Merge branch 'main' into feature/polls

703b4ff

Fix test

f25d559

Rename PollLayoutType.DEFAULT

a58879b

All other kord enums use camel case naming.

lukellmann added 3 commits September 3, 2024 00:30

Make DiscordPoll.results optional

3efd971

Fix KDoc references

39fcfb7

Move routes up

abe3347

lukellmann requested changes Sep 3, 2024

View reviewed changes

Remove imports

1ef1433

		"MESSAGE_POLL_VOTE_ADD" -> MessagePollVoteAdd(decode(MessagePollEventData.serializer()), sequence)
		"MESSAGE_POLL_VOTE_REMOVE" -> MessagePollVoteRemove(decode(MessagePollEventData.serializer()), sequence)

		public data class MessagePollVoteAdd(val data: MessagePollEventData, override val sequence: Int?) : DispatchEvent()
		public data class MessagePollVoteRemove(val data: MessagePollEventData, override val sequence: Int?) : DispatchEvent()

Implement polls #933

Are you sure you want to change the base?

Implement polls #933

Uh oh!

Conversation

DRSchlaubi commented Apr 9, 2024

Uh oh!

Moortu commented Aug 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukellmann commented Aug 19, 2024

Uh oh!

Moortu commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DRSchlaubi commented Aug 25, 2024

Uh oh!

lukellmann left a comment

Choose a reason for hiding this comment

Uh oh!

lukellmann Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukellmann commented Sep 6, 2024

Uh oh!

lukellmann commented Sep 7, 2024

Uh oh!

Moortu commented Dec 10, 2024

Uh oh!

lukellmann commented Dec 20, 2024

Uh oh!

DRSchlaubi commented Dec 20, 2024

Uh oh!

lukellmann commented Dec 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Moortu commented Aug 18, 2024 •

edited

Loading

Moortu commented Aug 19, 2024 •

edited

Loading

lukellmann Sep 2, 2024 •

edited

Loading