Prevent component destruction to support bfcache#476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable bfcache (Back/Forward Cache) support by preventing component destruction when the page is entering bfcache.
Browsers fire
pagehidewithevent.persisted = truewhen a page enters bfcache, andpageshowwithevent.persisted = truewhen restored. Previously, zoid treated everypagehideas a real navigation anddestroyed components — making them non-functional on bfcache restore.
Changes
Parent (
src/parent/parent.js):once()wrapper on thepagehidelistener so it can fire on every bfcache cycleevent.persistedguard — skipdestroy()when the page is entering bfcache, only destroy on real navigationwatchElementForClosecallback to trace rerender vs close pathsChild (
src/child/child.js):event.persistedguard on thepagehidelistener — skipcheckClosesignal when the page is entering bfcacheComponent (
src/component/component.js):rerender()path for debugging bfcache restore behaviorHow it works
persistedpagehidetruepagehidefalse/undefinedpageshowtrueRelated PRs
watchElementForClosebfcache fix (prevents sacrificial iframe from triggering false-positive rerender on bfcache restore)Test plan
test/tests/error.jsdispatchesnew Event("pagehide")withpersisted=undefined, which is falsy — guard does not skip it)