refactor EAP sample triggers and dependencies

[VGoncharova]

No description provided.

[coderabbitai]

Walkthrough

Replaces dependency- and trigger-based orchestration with artifact consumption in the TeamCity EAP samples trigger project. Removes the EAP branch filter constant, drops explicit dependency on the publish build, adds a parameter to skip dependency builds, and pulls the last successful publish artifact via an artifacts block.

Changes

Cohort / File(s)	Summary of Changes
TeamCity EAP orchestration \.teamcity/src/subprojects/train/TriggerProjectSamplesOnEAP.kt	- Removed EapConstants.EAP_BRANCH_FILTER - Replaced finishBuildTrigger and snapshot dependency with artifacts { buildRule = lastSuccessful() } for PUBLISH_EAP_BUILD_TYPE_ID - Added param("teamcity.build.skipDependencyBuilds", "true") in EAP version resolver project - Removed dependency on PUBLISH_EAP_BUILD_TYPE_ID and its failure/cancel handlers

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Fixed parameter reference to use the correct TeamCity syntax #142: Also modifies TriggerProjectSamplesOnEAP.kt to adjust EAP publish/version wiring and artifact rules, overlapping with the shift to artifact-based consumption.
• add TeamCity configuration for validating Ktor samples vs EAP versions #135: Introduced finishBuildTrigger/snapshot dependency flow and EAP branch filter that this PR removes.
• simplify EAP sample validation by removing reuseBuilds configuratio…n and updating eapVersionParam #140: Adjusts the same EAP sample orchestration toward artifact-based triggers for the publish EAP build, likely touching adjacent logic.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request currently lacks any description, leaving reviewers without context on the changes, which fails to meet the requirement of providing a summary related to the changeset.	Please add a concise description that outlines the purpose of the refactor, key changes to the EAP sample triggers and dependencies, and any relevant implementation details to help reviewers understand the update.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title accurately and concisely conveys the main change, namely the refactoring of EAP sample triggers and dependencies, and aligns with the changes in the code summary.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch vgoncharova/ktor-train

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d30650 and 2093fdf.

📒 Files selected for processing (1)

• .teamcity/src/subprojects/train/TriggerProjectSamplesOnEAP.kt (1 hunks)

🔇 Additional comments (1)

.teamcity/src/subprojects/train/TriggerProjectSamplesOnEAP.kt (1)

39-43: Empty artifact rules mean nothing gets downloaded

Right now artifactRules = "" results in the dependency being registered but no files fetched, so the resolver never actually consumes the publish artifacts. If the intent is to reuse metadata from the publish build, we should point the rule at the specific artifact(s); otherwise the block can’t deliver anything. Please update the rules (for example +:ktor-eap-version.txt => .) or confirm that the artifact dependency is no longer required.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}