simplify parameter definition in EAP sample triggers

[VGoncharova]

No description provided.

[coderabbitai]

Walkthrough

Updates TeamCity configuration: changes the published KTOR_VERSION build parameter key to env.KTOR_VERSION and renames the EAP version resolver dependency ID to KtorEAPVersionResolver, updating all build-type/composite references to the new resolver ID.

Changes

Cohort / File(s)	Summary of Changes
Trigger entrypoint .teamcity/src/subprojects/train/TriggerProjectSamplesOnEAP.kt	Replaced build parameter key teamcity.build.publishedAs.env.KTOR_VERSION with env.KTOR_VERSION and updated resolver dependency ID usage to KtorEAPVersionResolver.
Composite / per-sample build references .teamcity/.../EAP_KtorBuildPluginSamplesValidate_All*, .teamcity/.../EAP_KtorSamplesValidate_All*, .teamcity/.../KtorEAPSamplesCompositeBuild*, .teamcity/.../KtorEAPBuildPluginSamplesValidate_All*, .teamcity/.../KtorEAPSamplesValidate_All*	Replaced previous resolver dependency ID (TriggerProjectSamplesOnEAP_KtorEAPVersionResolver or similar) with the new ID KtorEAPVersionResolver in snapshot/dependency references across composite and sample validation build types.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• improve build status handling #149 — Modifies TriggerProjectSamplesOnEAP.kt and resolver/parameter naming; directly related to the same changes in this PR.
• update eap validation build #144 — Renames resolver/KTOR_VERSION handling; overlaps with the ID/key updates performed here.
• add failure conditions #146 — Touches TriggerProjectSamplesOnEAP.kt and the EAP resolver wiring; likely changes the same dependency references.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request lacks any description, providing no context or summary of the changes which makes it impossible to understand the author’s intent from the provided text.	Please add a concise description summarizing the changes, including the renaming of build parameters and resolver IDs, to clarify the purpose and scope of this pull request.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title concisely captures the primary change of simplifying parameter definitions within EAP sample triggers, which aligns with the modifications to build parameter keys and resolver IDs described in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch vgoncharova/ktor-train

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a1019a and 57a1a2c.

📒 Files selected for processing (1)

• .teamcity/src/subprojects/train/TriggerProjectSamplesOnEAP.kt (5 hunks)

🔇 Additional comments (2)

.teamcity/src/subprojects/train/TriggerProjectSamplesOnEAP.kt (2)

83-83: LGTM! Parameter key simplification is consistent.

The change from teamcity.build.publishedAs.env.KTOR_VERSION to env.KTOR_VERSION simplifies the parameter definition while maintaining the same functionality. The script on line 76 sets env.KTOR_VERSION, and all downstream builds correctly reference it as %dep.KtorEAPVersionResolver.env.KTOR_VERSION%.

---

118-118: Approve: no remaining old dependency ID references
Ripgrep search for TriggerProjectSamplesOnEAP_KtorEAPVersionResolver returned no matches; all IDs have been updated to KtorEAPVersionResolver.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}