Vgoncharova/ktor train

[VGoncharova]

Revert "update Ktor EAP trigger settings: enhance Node.js configuration for Kotlin JS, refine Maven POM modification logic, improve error handling, and optimize repository management"
Revert "update Ktor EAP trigger settings: refine failure conditions, improve Node.js configuration for multiplatform samples, update plugin initialization scripts, and optimize restoration logic for build files"

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This PR refactors EAP sample configuration in TriggerProjectSamplesOnEAP.kt by introducing modular settings generation functions, new build step helpers for root settings modification and restoration, and updated EAP orchestration flows. Changes include explicit plugin management content generation, Maven-specific build handling, and updated failure conditions with reduced execution timeouts.

Changes

Cohort / File(s)

Summary

EAP Settings and Build Step Refactoring .teamcity/src/subprojects/train/TriggerProjectSamplesOnEAP.kt

Introduced new public functions generateEAPPluginManagementContent(), modifyRootSettingsForEAP(), restoreRootSettings(), and buildEAPMavenSample(relativeDir: String). Reworked generateSettingsContent(isPluginSample) to return base settings with plugin/non-plugin sample distinction. Refactored asEAPSampleConfig() implementation. Updated BuildType.addEAPSampleFailureConditions() with new failure patterns and reduced timeout from 20 to 10 minutes. Reorganized EAP sample build wiring across Gradle plugin, Gradle, and Maven paths.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

• Key areas requiring attention:
  • New public function signatures and their integration points across EAP sample orchestration paths
  • Root settings modification and restoration logic flow across standalone vs. non-standalone builds
  • Failure condition changes and timeout reduction impact on EAP build reliability
  • Maven-specific EAP build handling and how it mirrors existing Gradle/plugin approaches

Possibly related PRs

• update Ktor EAP trigger settings: enhance version validation, restructure Gradle plugin resolution logic, improve failure conditions, and refine repository management #205 — Modifies the same EAP settings resolution flow by adding generateEAPPluginManagementContent, changing generateSettingsContent, and introducing modifyRootSettingsForEAP/restoreRootSettings/buildEAPMavenSample with updated failure-condition logic.
• update Ktor EAP trigger settings: refine Gradle plugin repository configuration, adjust included groups, and improve repository structure #202 — Changes EAP repository and plugin management in the same file with new generateEAPPluginManagementContent() and refactors plugin settings handling.
• update Ktor EAP trigger settings: add logic to modify and restore root gradle settings for EAP builds #192 — Directly uses modifyRootSettingsForEAP() and restoreRootSettings() in the same EAP build flow and updates non-standalone sample build steps.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch vgoncharova/ktor-train

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec67b23 and 88c218a.

📒 Files selected for processing (1)

• .teamcity/src/subprojects/train/TriggerProjectSamplesOnEAP.kt (8 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}