fix(operator): make RuntimeInfo thread-safe by using instance field

[Deepam02]

Fixes #2873

What this PR does / why we need it:

Quick fix for the data race when calling RuntimeInfo concurrently.

The issue was a global syncPodSets variable getting hammered by multiple goroutines at once. Moved it to an instance field in the Info struct so each call gets its own copy - no more shared state, no more race conditions.

Pretty straightforward change but I did an intensive code review to make sure it actually solves the problem. Traced through all the call sites and execution flows to verify each RuntimeInfo() creates an isolated instance with no shared mutable state between concurrent calls.

Which issue(s) this PR fixes:
Fixes #2873

Checklist:

• Docs included if any changes are user facing

[Deepam02]

Test Failures

The unit tests are failing because cmp.Diff cannot compare the new unexported syncPodSets field.

I'm not really sure how to proceed - should I change the tests or export it as SyncPodSets so tests work without changes?

[andreyvelich]

@Deepam02 You might need to explore why unit tests are failing

[tenzen-y]

Test Failures

The unit tests are failing because cmp.Diff cannot compare the new unexported syncPodSets field.

I'm not really sure how to proceed - should I change the tests or export it as SyncPodSets so tests work without changes?

You can leverage the cmp ignore options to ignore syncPods functions in tests.

[Deepam02]

@tenzen-y @andreyvelich please put a review

[andreyvelich]

/milestone v2.1

[coveralls]

Pull Request Test Coverage Report for Build 18921020248

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 5 of 9 (55.56%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.08%) to 51.754%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/runtime/runtime.go	5	9	55.56%

Totals
Change from base Build 18685746799:	0.08%
Covered Lines:	1269
Relevant Lines:	2452

---

💛 - Coveralls

[andreyvelich]

/assign @tenzen-y @astefanutti As we discussed we might want to merge this PR before v2.1

cc @kaisoz @mimowo

[mimowo]

As we discussed we might want to merge this PR before v2.1

Nice, but TBH it is not a blocker for Kueue, Also, I think it does not really impact API so could also be released in 2.1.1 for example.

[andreyvelich]

Make sense! As we talked today, this is not blocking, but "nice to have" feature.

[tenzen-y]

Thank you for working on this PR. This mostly LGTM
Could you fix the formatting errors?

You can fix with the following make command:

trainer/Makefile

Lines 157 to 160 in 6109d36

	# Instructions for code formatting.
	.PHONY: fmt
	fmt: ## Run go fmt against the code.
	go fmt ./...

[andreyvelich]

/ok-to-test

[tenzen-y]

I am assuming CI passed.
Thank you!
/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andreyvelich]

@Deepam02 Please can you rebase your PR to fix CI ?

[andreyvelich]

Thank you for this contribution @Deepam02!
This PR is superseded by: #2877
/close

[google-oss-prow]

@andreyvelich: Closed this PR.

In response to this:

Thank you for this contribution @Deepam02!
This PR is superseded by: #2877
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.