Skip to content

Conversation

@sachiniyer
Copy link
Contributor

@sachiniyer sachiniyer commented Oct 17, 2025

I believe 3a452ed broke cp from pod (I can't get it to work and get Error: Unexpected end of data messages). I created an issue with more info here - #2663

The tar-fs readme says that it does not gunzip automatically (like the previously used tar package did).

Apologies if I missed something here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2025
@cjihrig
Copy link
Contributor

cjihrig commented Oct 17, 2025

I don't know how much effort it would be, but is it possible to write a regression test (beyond checking the tar flags)? For example, we have this integration test that will run against an actual cluster.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2025
@sachiniyer
Copy link
Contributor Author

sachiniyer commented Oct 17, 2025

Yup @cjihrig ! I've added a previously failing integration test (if you make the flags zcf, you will see that this test fails as well).

Lmk, if there is anything unsatisfactory about the way I have written it.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. It looks really good. Just one tiny nit and then I'm good with this.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, sachiniyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit dee2426 into kubernetes-client:main Oct 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants