-
Notifications
You must be signed in to change notification settings - Fork 559
fix: cp from pod was broken #2664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cp from pod was broken #2664
Conversation
|
I don't know how much effort it would be, but is it possible to write a regression test (beyond checking the |
|
Yup @cjihrig ! I've added a previously failing integration test (if you make the flags Lmk, if there is anything unsatisfactory about the way I have written it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test. It looks really good. Just one tiny nit and then I'm good with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, sachiniyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I believe 3a452ed broke cp from pod (I can't get it to work and get
Error: Unexpected end of datamessages). I created an issue with more info here - #2663The tar-fs readme says that it does not gunzip automatically (like the previously used
tarpackage did).Apologies if I missed something here.