-
Couldn't load subscription status.
- Fork 3.4k
fix: prioritize current-context based on file order #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @hhk7734! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hhk7734 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
/remove-lifecycle stale |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind bug
(?)
What this PR does / why we need it:
kubectl config current-contextcommand retrieves the current-context from the first file with a non-empty value when multiple files are provided. In contrast, config.list_kube_config_contexts() returns the current-context from the last file with a value. Since developers are likely to expect the behavior aligned withkubectl, I created this PR to adjust the priority.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I'm guessing that https://github.com/kubernetes/client-go/blob/18a1faa115ed571de5af3e8f0f9c02973769ceb3/tools/clientcmd/loader.go#L246-L273 is relevant, and client-go probably works the same way.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: