Kicbase: fix docker driver with crio runtime: install dbus #21724

obnoxxx · 2025-10-10T11:53:00Z

minikube would not start a cluster successfully with docker driver and crio runtime due to missing dbus.

Changing the kicbase build to install the dbus package lets minikube start to complete successfully.

k8s-ci-robot · 2025-10-10T11:53:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: obnoxxx
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-10-10T11:53:09Z

Welcome @obnoxxx!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-10-10T11:53:10Z

Hi @obnoxxx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

minikube-bot · 2025-10-10T11:57:03Z

Can one of the admins verify this patch?

nirs

@obnoxxx thanks!

nirs · 2025-10-10T13:40:03Z

deploy/kicbase/clean-install


 apt-get update
-apt-get install -y --no-install-recommends -o DPkg::options::="--force-confdef" -o DPkg::options::="--force-confold" "$@"
+apt-get install -y -o DPkg::options::="--force-confdef" -o DPkg::options::="--force-confold" "$@"


Can you check and report in the commit/pr message which additional packages are installed, and how this affects the size of the image?

The issue with allowing recommended package is that we may install packages we don't need. The image will grow and will be slower to download and more expensive to server the builds.

In general it sounds like a packaging bug when installing required packages without recommended package ends in failure to use the install packages. We may need to report a Debian bug for this.

Ideally we can explicitly install the missing packages to make the requirement clear and link the Debian bug about this. When the bug is fixed we can remove the explicit requirement.

good points, @nirs! I get why recommended packages were originally excluded. But after @afbjorklund 's analysis in issue #21724, I realized that allowing recommended packages did fix the issue for me. I will check the resulting changes in size and packages and update.

Actually my recommendation was to add the "dbus" package, next to the "systemd" package.

Fix Crio in Kicbase to work with Default Kubernetes Version #21684 (comment)

--- a/deploy/kicbase/Dockerfile +++ b/deploy/kicbase/Dockerfile @@ -91,7 +91,7 @@ RUN echo "Ensuring scripts are executable ..." \ && chmod +x /usr/local/bin/clean-install /usr/local/bin/entrypoint \ && echo "Installing Packages ..." \ && DEBIAN_FRONTEND=noninteractive clean-install \ - systemd \ + systemd dbus \ conntrack iptables iproute2 ethtool socat util-linux mount ebtables udev kmod \ libseccomp2 pigz \ bash ca-certificates curl rsync \

The no-install-recommends flag was just the reason to why it was missing in the first place.

In general it sounds like a packaging bug when installing required packages without recommended package ends in failure to use the install packages. We may need to report a Debian bug for this.

I think they use "Suggests", for the things that are nice-to-have...

https://www.debian.org/doc/debian-policy/ch-relationships.html

Recommends: This declares a strong, but not absolute, dependency. The Recommends field should list packages that would be found together with this one in all but unusual installations.

So it installs "Recommends" by default (and breaks without "Depends")

@afbjorklund wrote:

Actually my recommendation was to add the "dbus" package, next to the "systemd" package.

The no-install-recommends flag was just the reason to why it was missing in the first place.

Got it.

I updated the PR accordingly and with local tests it looks good.

Thanks again for your analysis and recommendation!

nirs · 2025-10-10T13:40:30Z

/ok-to-build-image

minikube-bot · 2025-10-10T14:05:56Z

Hi @obnoxxx, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

obnoxxx · 2025-10-10T16:10:19Z

Hi @obnoxxx, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

Trying these changes locally, make allfails, while make and make local-kicbasesucceed.

I am unsure how ti integrate possible additional changes withe PR including this added commit.

@nirs , @medyagh - any hint?

nirs · 2025-10-10T17:06:58Z

Hi @obnoxxx, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

Trying these changes locally, make allfails, while make and make local-kicbasesucceed.

make all worked for me on Fedora 42 with docker installed. It doess not work on macOS without docker desktop, and I guess you don't want to install it.

Check how this is run in the CI, and use the same command:
hack/jenkins/minikube_cross_build_and_upload.sh

This should work:

BUILD_IN_DOCKER=y make all

We can probably improve the docs:
https://minikube.sigs.k8s.io/docs/contrib/building/binaries/

nirs · 2025-10-10T17:07:18Z

/ok-to-test

nirs · 2025-10-12T00:58:54Z

This is great improvement for Docker_Linux tests. It seems that test count is incorrect. Before this change we did not run many tests but they are not counted in the skipped tests.

Before

failed: 56
passed: 92
skipped: 18
total: 166

https://storage.googleapis.com/minikube-builds/logs/21681/41822/Docker_Linux_crio.html#

After

failed: 37
passed: 264
skipped: 26
total: 327

https://storage.googleapis.com/minikube-builds/logs/21724/41851/Docker_Linux_crio.html

obnoxxx · 2025-10-13T08:09:11Z

/retest

nirs · 2025-10-13T12:32:35Z

/ok-to-build-image

minikube-bot · 2025-10-13T12:55:07Z

Hi @obnoxxx, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

obnoxxx · 2025-10-13T12:59:08Z

/retest

nirs · 2025-10-13T13:41:41Z

/retitle kicbase: fix docker driver with crio runtime: install dbus

nirs · 2025-10-13T13:44:23Z

/ok-to-build-image

nirs · 2025-10-13T14:11:49Z

/retitle Kicbase: fix docker driver with crio runtime: install dbus

minikube-bot · 2025-10-13T14:13:56Z

Hi @obnoxxx, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

nirs · 2025-10-13T14:17:15Z

/ok-to-test

minikube would not start a cluster successfully with docker driver and crio runtime due to missing dbus packages Adding dbus packages to the kicbase image build lets minikube start to complete successfully. Signed-off-by: Michael Adam <[email protected]> Co-authored-by: Anders F Björklund <[email protected]>

obnoxxx · 2025-10-13T16:03:43Z

/retest-required

k8s-ci-robot · 2025-10-13T16:08:26Z

@obnoxxx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-minikube-integration	`cdde98f`	link	true	`/test pull-minikube-integration`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

medyagh · 2025-10-13T17:58:39Z

deploy/kicbase/Dockerfile

 && echo "Installing Packages ..." \
    && DEBIAN_FRONTEND=noninteractive clean-install \
-      systemd \
+      systemd dbus \


thank you for fixing many of the failures, curious is there any documentation that explains we need dbus ? if there are plz add to the PR description

minikube-pr-bot · 2025-10-13T21:45:38Z

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21724 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 43.9s    │ 43.8s                  │
│ enable ingress │ 16.2s    │ 17.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 46.3s 42.2s 45.1s 40.8s 45.2s
Times for minikube (PR 21724) start: 45.5s 44.0s 43.2s 42.6s 43.5s

Times for minikube (PR 21724) ingress: 20.4s 19.8s 15.8s 15.8s 15.9s
Times for minikube ingress: 16.9s 15.8s 16.9s 15.4s 15.9s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21724 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.8s    │ 23.1s                  │
│ enable ingress │ 10.9s    │ 11.7s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 22.3s 22.6s 23.3s 21.7s 24.2s
Times for minikube (PR 21724) start: 23.4s 23.6s 22.1s 23.4s 23.0s

Times for minikube ingress: 11.6s 10.6s 10.7s 10.7s 10.6s
Times for minikube (PR 21724) ingress: 10.7s 13.7s 12.7s 10.6s 10.7s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21724 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.1s    │ 21.3s                  │
│ enable ingress │ 20.2s    │ 20.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 20.9s 23.7s 23.1s 19.5s 23.2s
Times for minikube (PR 21724) start: 19.7s 23.0s 19.4s 20.9s 23.3s

Times for minikube ingress: 20.1s 20.2s 20.1s 20.1s 20.2s
Times for minikube (PR 21724) ingress: 20.2s 20.2s 21.2s 20.1s 21.1s

minikube-pr-bot · 2025-10-13T22:20:16Z

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Linux (1 failed)	TestSkaffold(gopogh)	0.00% (chart)

Besides the following environments also have failed tests:

Docker_Linux_crio_arm64: 38 failed (gopogh)
KVM_Linux_containerd: 21 failed (gopogh)

To see the flake rates of all tests by environment, click here.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2025

k8s-ci-robot requested review from medyagh and nirs October 10, 2025 11:53

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2025

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2025

obnoxxx force-pushed the fix-crio-kicbase branch from a04a725 to 4a996b3 Compare October 10, 2025 11:55

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 10, 2025

obnoxxx force-pushed the fix-crio-kicbase branch from 4a996b3 to 5f0f07f Compare October 10, 2025 12:25

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 10, 2025

nirs reviewed Oct 10, 2025

View reviewed changes

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2025

This comment has been minimized.

Sign in to view

obnoxxx force-pushed the fix-crio-kicbase branch from 4b13c2b to f817275 Compare October 13, 2025 08:04

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2025

This comment has been minimized.

Sign in to view

obnoxxx force-pushed the fix-crio-kicbase branch from 2c933d6 to d10bcbc Compare October 13, 2025 11:56

This comment has been minimized.

Sign in to view

obnoxxx force-pushed the fix-crio-kicbase branch from d10bcbc to a83898f Compare October 13, 2025 12:30

obnoxxx force-pushed the fix-crio-kicbase branch from a42e9d5 to 360d9e0 Compare October 13, 2025 12:55

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2025

This comment has been minimized.

Sign in to view

k8s-ci-robot changed the title ~~fix docker driver with crio runtime: install missing dbus packages~~ kicbase: fix docker driver with crio runtime: install dbus Oct 13, 2025

This comment has been minimized.

Sign in to view

k8s-ci-robot changed the title ~~kicbase: fix docker driver with crio runtime: install dbus~~ Kicbase: fix docker driver with crio runtime: install dbus Oct 13, 2025

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2025

obnoxxx and others added 2 commits October 13, 2025 16:21

Updating kicbase image to v0.0.48-1760363564-21724

cdde98f

obnoxxx force-pushed the fix-crio-kicbase branch from 53acf3a to cdde98f Compare October 13, 2025 14:23

medyagh reviewed Oct 13, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Kicbase: fix docker driver with crio runtime: install dbus #21724

Are you sure you want to change the base?

Kicbase: fix docker driver with crio runtime: install dbus #21724

Conversation

obnoxxx commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 10, 2025

Uh oh!

k8s-ci-robot commented Oct 10, 2025

Uh oh!

k8s-ci-robot commented Oct 10, 2025

Uh oh!

minikube-bot commented Oct 10, 2025

Uh oh!

nirs left a comment

Choose a reason for hiding this comment

Uh oh!

nirs Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

obnoxxx Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

afbjorklund Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

afbjorklund Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

obnoxxx Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

nirs commented Oct 10, 2025

Uh oh!

minikube-bot commented Oct 10, 2025

Uh oh!

obnoxxx commented Oct 10, 2025

Uh oh!

nirs commented Oct 10, 2025

Uh oh!

nirs commented Oct 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

nirs commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

obnoxxx commented Oct 13, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

nirs commented Oct 13, 2025

Uh oh!

minikube-bot commented Oct 13, 2025

Uh oh!

obnoxxx commented Oct 13, 2025

Uh oh!

This comment has been minimized.

nirs commented Oct 13, 2025

Uh oh!

nirs commented Oct 13, 2025

Uh oh!

This comment has been minimized.

nirs commented Oct 13, 2025

Uh oh!

minikube-bot commented Oct 13, 2025

Uh oh!

nirs commented Oct 13, 2025

Uh oh!

obnoxxx commented Oct 13, 2025

Uh oh!

k8s-ci-robot commented Oct 13, 2025

Uh oh!

medyagh Oct 13, 2025

Choose a reason for hiding this comment

obnoxxx commented Oct 10, 2025 •

edited

Loading

afbjorklund Oct 10, 2025 •

edited

Loading

afbjorklund Oct 10, 2025 •

edited

Loading

nirs commented Oct 12, 2025 •

edited

Loading