Chore: upgrade go and k8s version #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 30, 2025 10:20
Signed-off-by: Pushparaj Shetty K S <[email protected]>
Signed-off-by: Pushparaj Shetty K S <[email protected]>
Signed-off-by: Pushparaj Shetty K S <[email protected]>
Signed-off-by: Pushparaj Shetty K S <[email protected]>
Signed-off-by: Pushparaj Shetty K S <[email protected]>
Signed-off-by: Pushparaj Shetty K S <[email protected]>
Signed-off-by: Pushparaj Shetty K S <[email protected]>
PushparajShetty
force-pushed
the
chore/upgrade-go-k8s-version
branch
from
1475ff8 to
ee52ee1
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 7 issues across 16 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
|
|
||
| # Produce CRDs that work back to Kubernetes 1.11 (no version conversion) | ||
| CRD_OPTIONS ?= "crd:trivialVersions=true" | ||
| CRD_OPTIONS ?= "crd" |
There was a problem hiding this comment.
Removing trivialVersions=true from CRD_OPTIONS may cause issues with CRD compatibility for clusters older than Kubernetes 1.13, as version conversion will not be handled. Ensure this is intentional and compatible with your supported Kubernetes versions.
Suggested change
| CRD_OPTIONS ?= "crd" | |
| CRD_OPTIONS ?= "crd:trivialVersions=true" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Upgraded Go to 1.23.8 and Kubernetes dependencies to the latest supported versions. Updated related workflows, CRDs, and tools to ensure compatibility.