fix(path-compression): CVE-2025-3445 #2731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears the build is failing due to auth issues only? @kurtosis-tech/engineers, @tedim52 - I believe this is ready for review. |
|
Hey @scharissis - will take a look at this today. |
|
Hey @tedim52 , let me know if you have any questions on this or if I can help progress it in any way. |
tedim52
reviewed
Apr 30, 2025
| require.NoError(t, err) | ||
| require.Equal(t, compressedDataBytes, compressedDataBytesAgain) | ||
| require.Equal(t, sizeAgain, size) |
There was a problem hiding this comment.
What's the reason for removing the check between the previous hash and the new hash size?
There was a problem hiding this comment.
They no longer match.
My assumption was that the compression algorithm changed and that this isn't actually an important invariant to be maintained or tested.
Is this true?
tedim52
reviewed
Apr 30, 2025
Replaced the deprecated mholt/archiver with the new mholt/archives, in the process addressing security vulnerability CVE-2025-3445. See: https://nvd.nist.gov/vuln/detail/CVE-2025-3445
scharissis
force-pushed
the
scharissis/fix-CVE-2025-3445
branch
from
c4e96d3 to
bf837cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the deprecated mholt/archiver with the new mholt/archives, in the process addressing security vulnerability CVE-2025-3445. See: https://nvd.nist.gov/vuln/detail/CVE-2025-3445
Is this change user facing?
NO
References (if applicable)
https://nvd.nist.gov/vuln/detail/CVE-2025-3445