-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[docs]: update README.md #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: update README.md #1615
Conversation
Summary of ChangesHello @KMSorSMS, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the developer experience by introducing detailed contribution guidelines and making the Git pre-commit hooks more robust and compatible with a monorepo setup. It also includes general code formatting improvements across various Python scripts and a minor dependency adjustment in the MOE kernel, alongside a small cleanup in the main README documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on adapting the repository for a monorepo structure by updating documentation, build scripts, and Git hooks. A new CONTRIBUTING.md file has been added, and various scripts have been refactored to be aware of the new directory layout. The changes are generally well-implemented and improve the developer workflow. However, I've identified a high-severity issue in the pre-commit hook that could cause it to fail for developers with spaces in their repository path. A code suggestion to fix this has been provided.
| BLACK_PATHS="" | ||
| if [ -d "$KERNEL_DIR/python" ]; then | ||
| BLACK_PATHS="$BLACK_PATHS $KERNEL_DIR/python" | ||
| fi | ||
| if [ -d "$KERNEL_DIR/scripts" ]; then | ||
| BLACK_PATHS="$BLACK_PATHS $KERNEL_DIR/scripts" | ||
| fi | ||
| if [ -n "$BLACK_PATHS" ]; then | ||
| echo "[pre-commit] running black on:$BLACK_PATHS" >&2 | ||
| # shellcheck disable=SC2086 | ||
| $BLACK_BIN $BLACK_PATHS | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current method of constructing BLACK_PATHS as a space-separated string is not robust and will fail if the repository path contains spaces. The shell will perform word splitting on the unquoted $BLACK_PATHS variable, passing incorrect paths to black. Using a bash array to store the paths and then expanding it with "${BLACK_PATHS[@]}" ensures that each path is passed as a single, correctly quoted argument, making the script reliable for all users regardless of their directory structure.
| BLACK_PATHS="" | |
| if [ -d "$KERNEL_DIR/python" ]; then | |
| BLACK_PATHS="$BLACK_PATHS $KERNEL_DIR/python" | |
| fi | |
| if [ -d "$KERNEL_DIR/scripts" ]; then | |
| BLACK_PATHS="$BLACK_PATHS $KERNEL_DIR/scripts" | |
| fi | |
| if [ -n "$BLACK_PATHS" ]; then | |
| echo "[pre-commit] running black on:$BLACK_PATHS" >&2 | |
| # shellcheck disable=SC2086 | |
| $BLACK_BIN $BLACK_PATHS | |
| fi | |
| declare -a BLACK_PATHS=() | |
| if [ -d "$KERNEL_DIR/python" ]; then | |
| BLACK_PATHS+=("$KERNEL_DIR/python") | |
| fi | |
| if [ -d "$KERNEL_DIR/scripts" ]; then | |
| BLACK_PATHS+=("$KERNEL_DIR/scripts") | |
| fi | |
| if [ ${#BLACK_PATHS[@]} -gt 0 ]; then | |
| echo "[pre-commit] running black on: ${BLACK_PATHS[*]}" >&2 | |
| "$BLACK_BIN" "${BLACK_PATHS[@]}" | |
| fi |
No description provided.