Skip to content

Conversation

@KMSorSMS
Copy link
Collaborator

What does this PR do?

Add issue config so that the user can be aware of the QA

Before submitting

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @KMSorSMS, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the repository's issue management by adding a new issue configuration file. This change aims to streamline the issue reporting process by guiding users to existing resources, such as an FAQ, before they submit new issues, thereby improving the overall quality and efficiency of community support.

Highlights

  • Issue Configuration: Introduced a new config.yml file within the .github/ISSUE_TEMPLATE directory to manage issue creation settings.
  • Blank Issues Enabled: The new configuration explicitly enables the creation of blank issues, providing flexibility for users.
  • FAQ Contact Link: Added a contact link to a comprehensive FAQ page (🚨FAQs | 常见问题🚨 hiyouga/LLaMA-Factory#4614) within the issue creation flow, recommending users to read it beforehand.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a GitHub issue configuration file to guide users when creating new issues. My review focuses on improving the effectiveness of this configuration. I've suggested correcting the FAQ link to point to this repository's own FAQ and disabling blank issues to better direct users to the provided templates and resources. These changes should help achieve the PR's goal of making users more aware of the project's QA process.

blank_issues_enabled: true
contact_links:
- name: 📚 FAQs | 常见问题
url: https://github.com/hiyouga/LLaMA-Factory/issues/4614
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The URL for the FAQ points to the LLaMA-Factory repository, which seems incorrect for this project (ktransformers). It should likely point to an FAQ relevant to this repository. Based on doc/en/FAQ.md, a more appropriate URL would be https://github.com/kvcache-ai/ktransformers/issues/1608.

    url: https://github.com/kvcache-ai/ktransformers/issues/1608

@@ -0,0 +1,5 @@
blank_issues_enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To better guide users towards using issue templates and reading the FAQ as intended by this PR, consider disabling blank issues. This encourages users to select a specific template or follow the contact links provided, rather than opening an empty issue. This aligns with the goal of making users 'aware of the QA'.

blank_issues_enabled: false

@KMSorSMS KMSorSMS merged commit f914bc4 into kvcache-ai:main Nov 16, 2025
6 checks passed
@KMSorSMS KMSorSMS deleted the issue_config branch November 16, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant