Skip to content

Conversation

@gumulka
Copy link
Contributor

@gumulka gumulka commented Aug 11, 2025

Description

Some devices do not allow USB Serial Download read commands, which will result in a failure, when trying to verify the correctness of the image. Make the verify step optional but on by default.

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested
  • Man pages have been regenerated

Test has been done by creating a minimal place and setting verify to True, False and leaving it empty.

targets:
  main:
    resources:
    - RemotePlace:
        name: "myboard"
    drivers:
    - IMXUSBDriver:
        verify: False

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.4%. Comparing base (0ba0f75) to head (f2d3cbb).
⚠️ Report is 17 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/driver/usbloader.py 20.0% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0ba0f75) and HEAD (f2d3cbb). Click for more details.

HEAD has 65 uploads less than BASE
Flag BASE (0ba0f75) HEAD (f2d3cbb)
3.11 14 1
3.10 14 1
3.9 14 1
3.12 14 1
3.13 14 1
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1714      +/-   ##
=========================================
- Coverage    55.6%   45.4%   -10.3%     
=========================================
  Files         172     172              
  Lines       13462   13500      +38     
=========================================
- Hits         7491    6130    -1361     
- Misses       5971    7370    +1399     
Flag Coverage Δ
3.10 45.4% <20.0%> (-10.3%) ⬇️
3.11 45.4% <20.0%> (-10.3%) ⬇️
3.12 45.4% <20.0%> (-10.3%) ⬇️
3.13 45.3% <20.0%> (-10.3%) ⬇️
3.9 45.4% <20.0%> (-10.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Emantor
Copy link
Member

Emantor commented Aug 12, 2025

The documentation under doc/configuration.rst needs to be updated, also please provide an example of a device where the read command no longer succeeds for the configuration option in the documentation so users have a breadcrumb to find when to disable the verification.

@gumulka
Copy link
Contributor Author

gumulka commented Aug 12, 2025

@Emantor Is this enough of a hint, or should it be more elaborate?

Emantor
Emantor previously approved these changes Aug 12, 2025
Some devices do not allow USB Serial Download read commands, which will
result in a failure, when trying to verify the correctness of the image.
Make the verify step optional but on by default.

Signed-off-by: Fabian Pflug <[email protected]>
Discribing what verify does and when it is needed to set to false.

Signed-off-by: Fabian Pflug <[email protected]>
@Bastian-Krause Bastian-Krause merged commit e9e43aa into labgrid-project:master Sep 13, 2025
9 of 11 checks passed
@gumulka gumulka deleted the conditionally_check_imxusbloader branch September 13, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants