Skip to content

chore(ci): bump golangci-lint to v2.5.0 #5752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 29 commits into from
Closed

chore(ci): bump golangci-lint to v2.5.0 #5752

wants to merge 29 commits into from
+12,185 −7,077

Conversation

zijiren233
Copy link
Member

@zijiren233 zijiren233 commented Aug 1, 2025 •
edited
Loading

PR: Bump golangci-lint to v2.3.1

need close #5755

📋 Task Assignment & Completion Status

Services Group

Status Module Assignee
✅ golangci-lint (./service/devbox) @zijiren233
✅ golangci-lint (./service/vlogs) @zijiren233
✅ golangci-lint (./service/pay) @zijiren233
✅ golangci-lint (./service/exceptionmonitor) @zijiren233
✅ golangci-lint (./service) @zijiren233
⬜ golangci-lint (./service/account) @bxy4543
✅ golangci-lint (./service/database) @zijiren233
✅ golangci-lint (./service/launchpad) @zijiren233

Controllers Group

Status Module Assignee
✅ golangci-lint (./controllers/db/adminer) @zijiren233
✅ golangci-lint (./controllers/devbox) @zijiren233
✅ golangci-lint (./controllers/pkg) @zijiren233
✅ golangci-lint (./controllers/resources) @zijiren233
✅ golangci-lint (./controllers/user) @zijiren233
✅ golangci-lint (./controllers/terminal) @lingdie
✅ golangci-lint (./controllers/job/init) @zijiren233
✅ golangci-lint (./controllers/job/heartbeat) @zijiren233
✅ golangci-lint (./controllers/app) @zijiren233
✅ golangci-lint (./controllers/license) @zijiren233
✅ golangci-lint (./controllers/objectstorage) @zijiren233
✅ golangci-lint (./controllers/db) @zijiren233
✅ golangci-lint (./controllers/account) @zijiren233
✅ golangci-lint (./controllers/node) @zijiren233

Kubernetes Group

Status Module Assignee
⬜ golangci-lint (./lifecycle) @cuisongliu

Note: Replace ⬜ with ✅ when completed

🛠️ Local Testing & Quick Fix Guide

To test and fix lint issues locally:

# Navigate to your module directory
cd controllers/account

# Run linter to check for issues
golangci-lint-v2 run --color=always --config=../../.golangci.yml

# Auto-fix issues (only for linters that support --fix)
golangci-lint-v2 run --color=always --config=../../.golangci.yml --fix

Note: The --fix flag only works for certain linters. Manual fixes may still be required for some issues.

@zijiren233 zijiren233 changed the title chore: bumo golangci-lint to v2.3.0 chore: bump golangci-lint to v2.3.0 Aug 1, 2025
@zijiren233 zijiren233 force-pushed the bump-golangci-lint branch 2 times, most recently from 3115421 to fffc65d Compare August 2, 2025 10:00
@zijiren233 zijiren233 changed the title chore: bump golangci-lint to v2.3.0 chore: bump golangci-lint to v2.3.1 Aug 4, 2025
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Aug 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@labring labring deleted a comment from cla-assistant bot Aug 6, 2025
@pull-request-size Pull Request Size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

zijiren233 and others added 19 commits October 14, 2025 11:10
@zijiren233
fix: service databse ci lint (#110)
9b4fafa
@zijiren233
fix: service exceptionmonitor ci lint (#111)
cd8c81c
@zijiren233
fix: service minio ci lint (#112)
b8ce96d
@zijiren233
fix: service pay and vlogs ci lint (#113)
ac06f01 
* fix: service pay and vlogs ci lint

* fix: pay ci lint
@zijiren233
fix: service ci lint (#114)
312f2be
@zijiren233
fix: controller app ci lint (#115)
64ebafb
@zijiren233
fix: controller node ci lint (#116)
09d36d4
@zijiren233
fix: controller resources ci lint (#117)
1af527e
@zijiren233
fix: controller job ci lint (#118)
5fb1d42
@zijiren233
fix: controller user ci lint (#119)
4f876b8
@zijiren233
fix: controller objectstorage ci lint (#120)
f09a8fc 
* fix: controller objectstorage ci lint

* fix: main.go gofumpt lint error
@zijiren233
fix: controller devbox ci lint (#121)
a8e8eae
@zijiren233
fix: controller account ci lint (#122)
cdfb2ec
@zijiren233
fix: controller license ci lint (#123)
f00e386
@zijiren233
fix: controller adminer ci lint (#124)
ba64c8f
@zijiren233
fix: controller pkg ci lint (#125)
1895675
@zijiren233
fix: pkg file format
1c59b6b
@zijiren233
fix: webhook ci lint (#126)
e7d5da3
@cuisongliu @zijiren233
fix: lifecycle ci lint (#127)
9c8c382 
* fix: standardize variable naming conventions in cert generation functions

Signed-off-by: cuisongliu <[email protected]>

* fix: use file permissions from header for directory creation in compress.go

Signed-off-by: cuisongliu <[email protected]>

* fix: add G402 linter rule to golangci configuration

Signed-off-by: cuisongliu <[email protected]>

* fix: update go.mod and go.sum to remove unused dependencies and add missing ones

Signed-off-by: cuisongliu <[email protected]>

* fix: add nolint directive for musttag in crictl_checker.go

Signed-off-by: cuisongliu <[email protected]>

* fix: delete progress_download.go

Signed-off-by: cuisongliu <[email protected]>

* fix: refactor bailOnError function to simplify parameters and improve error logging

Signed-off-by: cuisongliu <[email protected]>

* fix: refactor server URL construction to use net.JoinHostPort for consistency

Signed-off-by: cuisongliu <[email protected]>

* fix: simplify function signatures and improve error handling in various files. fix golang lint unparam.

Signed-off-by: cuisongliu <[email protected]>

* fix: golangci lint predeclared.

Signed-off-by: cuisongliu <[email protected]>

* fix: golangci lint prealloc.

Signed-off-by: cuisongliu <[email protected]>

* fix: remove unused imports and simplify code formatting in test files

Signed-off-by: cuisongliu <[email protected]>

* fix(image-cri-shim): improve code formatting and consistency across multiple files

Signed-off-by: cuisongliu <[email protected]>

* fix: add missing error import in server.go

Signed-off-by: cuisongliu <[email protected]>

* fix(lvscare): improve code formatting and consistency across multiple files

Signed-off-by: cuisongliu <[email protected]>

* fix(e2e): improve code formatting and consistency across multiple files

Signed-off-by: cuisongliu <[email protected]>

* fix(yaml): optimize slice initialization in MarshalConfigs function

Signed-off-by: cuisongliu <[email protected]>

* fix: format code use gofmt

Signed-off-by: cuisongliu <[email protected]>

* fix: clean up import statements across multiple files

Signed-off-by: cuisongliu <[email protected]>

---------

Signed-off-by: cuisongliu <[email protected]>
@zijiren233 zijiren233 requested review from a team as code owners October 14, 2025 03:20
@zijiren233 zijiren233 changed the title chore: bump golangci-lint to v2.3.1 ci: bump golangci-lint to v2.3.1 Oct 14, 2025
@zijiren233 zijiren233 changed the title ci: bump golangci-lint to v2.3.1 ci: bump golangci-lint to v2.5.0 Oct 14, 2025
@zijiren233 zijiren233 changed the title ci: bump golangci-lint to v2.5.0 chore(ci): bump golangci-lint to v2.5.0 Oct 14, 2025
@zijiren233 zijiren233 closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zijiren233 zijiren233

Labels

area/api area/apply sealos run/apply/scale/reset area/bootstrap area/buildah abount buildah sdk area/check area/ci area/cloud area/clusterfile area/command area/config area/env area/filesystem area/guest area/imageCRIShim about image-cri-shim area/ipvs area/lifecycle-management area/lvscare about lvscare area/registry area/runtime area/ssh area/test area/workflow size/XXL

Projects

None yet

Milestone

v5.1

Development

Successfully merging this pull request may close these issues.

Feature: bump golangci-lint to v2.3.0

5 participants

@zijiren233 @cuisongliu @bxy4543 @bearslyricattack @lingdie