-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Devbox daemon v2 #5781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Devbox daemon v2 #5781
Conversation
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
60ded10
to
45af8cb
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5781 +/- ##
=======================================
Coverage 61.97% 61.97%
=======================================
Files 8 8
Lines 647 647
=======================================
Hits 401 401
Misses 200 200
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
* Commit * fix conflict * commit container * delete container * stdout * Gc Handler * ctx * unit test * pull i * unit test * go mod * fix err * gc unit test * delete useless * rename * rename * import order --------- Co-authored-by: Cunzili <[email protected]>
* Add acceptance scoring for devbox scheduling and implement filesystem stats provider * Fix typo in ContainerFsStats method name * Add CPU request and limit ratio fields to AcceptanceConsideration struct * Add memory request and limit ratio fields to AcceptanceConsideration struct * Add annotations and default values for container resource ratios in Devbox * Rename container filesystem threshold annotation and update related logic to use available threshold * Change acceptanceThreshold type from uint to int and update related logic
… for container filesystem stats (#42)
* Increase example values for available and capacity bytes in ContainerFsStats * Refactor resource ratio types to use float64 in acceptance consideration calculations * Change error logging to info level for parsing failures in acceptance consideration
* Modify acceptance score calculation by using storage limit consideration instead and refactor related methods * Rename ratio functions and add up cpu by Value() instead of MilliValue() * Increase example values for available and capacity bytes to 100G/200G
Co-authored-by: Cunzili <[email protected]>
Co-authored-by: Cunzili <[email protected]>
* add push image func --------- Co-authored-by: Cunzili <[email protected]>
Co-authored-by: Cunzili <[email protected]>
* resolve conflict * fix container name and add remove containerID check --------- Co-authored-by: Cunzili <[email protected]>
63a284a
to
be6c2a1
Compare
Signed-off-by: Yun Pan <[email protected]>
Co-authored-by: Cunzili <[email protected]>
* remove lv after delete devbox remove lv during delete devbox remove lv during delete devbox * extend event handler --------- Co-authored-by: Cunzili <[email protected]>
* improve controller and state change handler * add validation
* close merge * add flag to merge --------- Co-authored-by: Cunzili <[email protected]>
This pull request makes significant changes to the Devbox controller API by removing the
DevBoxRelease
andOperationRequest
CRDs, refactoring the commit history structure, and updating several fields and annotations in the main Devbox API. It also updates tool versions and cleans up unused fields, which streamlines the codebase and improves maintainability.API Resource Removal
DevBoxRelease
andOperationRequest
custom resource definitions (CRDs) from the API, including all related type definitions and generated deepcopy methods. This simplifies the API and reduces maintenance overhead. [1] [2] [3] [4]Commit History Refactor
CommitHistory
struct with a newCommitRecord
struct andCommitRecordMap
, updating all related fields and generated deepcopy logic to support a more flexible commit tracking model. [1] [2] [3] [4]DevboxSpec and DevboxStatus Updates
DevboxSpec
, such asStorageLimit
and improved defaulting and validation forstate
. UpdatedDevboxStatus
to includecontentID
, a defaultstate
, and the newcommitRecords
field. [1] [2] [3] [4]Ports
,AppPorts
, andExtraPorts
from the API and deepcopy logic. [1] [2] [3] [4]Tooling and Version Updates
CONTROLLER_TOOLS_VERSION
in the Makefile fromv0.14.0
tov0.16.0
to use the latest code generation tools.These changes modernize and simplify the Devbox API, making it easier to maintain and extend in the future.