feat!: make v2 manifest default #5656
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojiaodoubao
force-pushed
the
v2-manifest-default
branch
from
171d787 to
839efcd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wojiaodoubao
force-pushed
the
v2-manifest-default
branch
from
839efcd to
d20720f
Compare
Contributor
Author
|
Hi @westonpace @wjones127 , could you help review this when you have time, thanks very much~ |
wjones127
changed the title
wjones127
requested changes
Jan 8, 2026
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
I think you missed one or two places.
Also, I've labelled this PR as a breaking change, since changed in default settings are considered breaking changes.
wojiaodoubao
force-pushed
the
v2-manifest-default
branch
from
882c6ad to
6360e7a
Compare
Contributor
Author
|
This pr is updated, please help review when you have time, thanks very much~ @wjones127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: defaults new datasets to use V2 manifest path naming scheme. This makes these datasets unreadable for versions of Lance library prior to v0.17.0 (released September 2024).
This default improves performance on object storage. See the original PR (#2798) for details.
Close #5634