fix(aws): inference config and system message | ChatBedrockConverse #9324
+333
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment.
Thank you @nityam2002 for the contribution. Can we have some unit tests for this to ensure we don't regress in the future?
Author
|
@christian-bromann added it! |
…ng in ChatBedrockConverse **chat_models:** conditionally include `inferenceConfig` & `system` for Bedrock Converse * Build a candidate `inferenceConfig`; only send it if any of `maxTokens`, `temperature`, `topP`, or non-empty `stopSequences` are set. * Include `system` only when it’s a non-empty array in both `ConverseCommand` and `ConverseStreamCommand`. * Prevents Bedrock `ValidationException` about overriding `inferenceConfig`/`system` at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chat_models: conditionally include
inferenceConfig&systemfor Bedrock ConverseinferenceConfig; only send it if any ofmaxTokens,temperature,topP, or non-emptystopSequencesare set.systemonly when it’s a non-empty array in bothConverseCommandandConverseStreamCommand.ValidationExceptionabout overridinginferenceConfig/systemat runtime.Fixes #9310