Skip to content

[11.x] Refactor NotIn rule to extend In rule #53240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[11.x] Refactor NotIn rule to extend In rule #53240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 1 addition & 44 deletions src/Illuminate/Validation/Rules/NotIn.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,55 +2,12 @@

namespace Illuminate\Validation\Rules;

use Illuminate\Contracts\Support\Arrayable;
use Stringable;

use function Illuminate\Support\enum_value;

class NotIn implements Stringable
class NotIn extends In
{
/**
* The name of the rule.
*
* @var string
*/
protected $rule = 'not_in';

/**
* The accepted values.
*
* @var array
*/
protected $values;

/**
* Create a new "not in" rule instance.
*
* @param \Illuminate\Contracts\Support\Arrayable|\BackedEnum|\UnitEnum|array|string $values
* @return void
*/
public function __construct($values)
{
if ($values instanceof Arrayable) {
$values = $values->toArray();
}

$this->values = is_array($values) ? $values : func_get_args();
}

/**
* Convert the rule to a validation string.
*
* @return string
*/
public function __toString()
{
$values = array_map(function ($value) {
$value = enum_value($value);

return '"'.str_replace('"', '""', $value).'"';
}, $this->values);

return $this->rule.':'.implode(',', $values);
}
}