Skip to content

Add detailed error handling in non-production environments for verifyUserCanAccessChannel method #53281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
doganarif wants to merge 2 commits into from
Closed

Add detailed error handling in non-production environments for verifyUserCanAccessChannel method #53281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96245f3
Add environment-based error handling to verifyUserCanAccessChannel me…
doganarif Oct 23, 2024
e20d1ee
missing facede import for application environment
doganarif Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Illuminate/Broadcasting/Broadcasters/Broadcaster.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Illuminate\Contracts\Routing\UrlRoutable;
use Illuminate\Support\Arr;
use Illuminate\Support\Reflector;
use Illuminate\Support\Facades\App;
use ReflectionClass;
use ReflectionFunction;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
Expand Down Expand Up @@ -119,13 +120,21 @@ protected function verifyUserCanAccessChannel($request, $channel)
$result = $handler($this->retrieveUser($request, $channel), ...$parameters);

if ($result === false) {
throw new AccessDeniedHttpException;
if (App::environment('production')) {
throw new AccessDeniedHttpException;
} else {
throw new AccessDeniedHttpException('User does not have access to this channel.');
}
} elseif ($result) {
return $this->validAuthenticationResponse($request, $result);
}
}

throw new AccessDeniedHttpException;
if (App::environment('production')) {
throw new AccessDeniedHttpException;
} else {
throw new AccessDeniedHttpException('No matching pattern found or user authentication failed.');
}
}

/**
Expand Down
Loading