Fix code for invalid locale for number class. if provided locale is not valid throws exception #53318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot valid throws exception.
…ot valid throws exception.
crynobone
requested changes
Oct 28, 2024
src/Illuminate/Support/Number.php
Outdated
| $availableLocales = ResourceBundle::getLocales(''); | ||
|
|
||
| if ( ! in_array($locale, $availableLocales, true)){ | ||
| throw new \Exception("Locale is invalid"); |
Member
There was a problem hiding this comment.
Should be InvalidArgumentException
Member
|
I think it's ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix code for invalid locale for number class. if provided locale is not valid throws exception.
Existing behaviour: If locale is invalid, falback en is used.
Updated behaviour: if locale is invalid throws an exception as Locale is invalid.
Note: A test is also added.