Skip to content

Add Enum inside app\Enums Directory #53719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add Enum inside app\Enums Directory #53719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bc0541
ref: add default namespace of enum to Enums directory
dipesh79 Nov 30, 2024
3a64c5d
fix: test updated
dipesh79 Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Console/EnumMakeCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ protected function getDefaultNamespace($rootNamespace)
return match (true) {
is_dir(app_path('Enums')) => $rootNamespace.'\\Enums',
is_dir(app_path('Enumerations')) => $rootNamespace.'\\Enumerations',
default => $rootNamespace,
default => $rootNamespace.'\\Enums',
Comment on lines 73 to +75
Copy link
Contributor

@shaedrich shaedrich Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't is_dir(app_path('Enums')) and default now redundant?

};
}

Expand Down
12 changes: 6 additions & 6 deletions tests/Integration/Generators/EnumMakeCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ public function testItCanGenerateEnumFile()
->assertExitCode(0);

$this->assertFileContains([
'namespace App;',
'namespace App\Enums;',
'enum StatusEnum',
], 'app/StatusEnum.php');
], 'app/Enums/StatusEnum.php');
}

public function testItCanGenerateEnumFileWithString()
Expand All @@ -30,9 +30,9 @@ public function testItCanGenerateEnumFileWithString()
->assertExitCode(0);

$this->assertFileContains([
'namespace App;',
'namespace App\Enums;',
'enum StringEnum: string',
], 'app/StringEnum.php');
], 'app/Enums/StringEnum.php');
}

public function testItCanGenerateEnumFileWithInt()
Expand All @@ -41,9 +41,9 @@ public function testItCanGenerateEnumFileWithInt()
->assertExitCode(0);

$this->assertFileContains([
'namespace App;',
'namespace App\Enums;',
'enum IntEnum: int',
], 'app/IntEnum.php');
], 'app/Enums/IntEnum.php');
}

public function testItCanGenerateEnumFileInEnumsFolder()
Expand Down