[12.x] Ensure calling job within a group works as expected

[jackbayliss]

When upgrading from 12.31 to 12.32 its stopping composer from updating:

> @php artisan package:discover --ansi

In CallbackEvent.php line 141:
                                                                               
  A scheduled event name is required to prevent overlapping. Use the 'name' m  
  ethod before 'withoutOverlapping'.                                           
                                                                               

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1
                                   

This happens due to using Schedule::job within a group that uses withoutOverlapping and seems to have been introduced via #57156

This approach makes the event directly, and merges any pending attributes afterwards and ensures the name is set, which works as expected.

The alternative is to revert the above change, but then groups won't work as expected either 😢

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[taylorotwell]

@jamessa can you take a look at this please?

[jamessa]

@taylorotwell I'v tested it - looks good to me.

@jackbayliss Good fix 👏. It might be worth a follow-up PR to merge this fix back to Schedule::mergePendingAttributes method by inserting $event->name($this->attributes?->description); as an one line fix.

This also fixes potential onOneServer issue.

The reason this backfires is that previously the event name was taken from the last pending attributes. The new implementation removes that reference, so the event name becomes null.