-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[12.x] Use Container::getInstance()
in ComposerScripts::prePackageUninstall()
#57226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still need
require_once $bootstrapFile;
and we haveContainer::getInstance()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
require_once $bootstrapFile
fetches the user-defined Application builder. This will resolve the Container's instance during its setup.The first time you call
require_once $bootstrapFile
, it does return an instance ofApplication
. If you call it again during the life-cycle, it just returnstrue
. (See the documentation forinclude_once
where this behavior is mentioned).The reason this is necessary is if you call
composer remove laravel/telescope laravel/boost
, this does not tear down and reboot the php interpreter for each package being removed. So for the first package removed,ComposerScripts::prePackageUninstall()
is called, whererequire_once
DOES return the application, but for the second packagerequire_once
just returns true.Thus, this change:
bootstrap/app.php
)Let me know if that makes sense or if you have any other questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That makes sense now. Other small question; do you think we should document the work done in #57144 and laravel/telescope#1641 in the package documentation, so developers can use this feature in their own packages when they need to register a service provider in the
bootstrap/providers.php
file?