[12.x] Add validation for password_hash() failure in hashers #57368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
password_hash()
function can returnfalse
on failure (invalidparameters, memory exhaustion, etc.), but the
make()
methods in bothBcryptHasher
andArgonHasher
only caughtError
exceptions and didn'tvalidate the return value. This creates:
@return string
but could return
false
false
is stored as a hash, it could lead toauthentication issues
behavior occurs
Changes
BcryptHasher.php:65-67