fix: correctly handle route parameters with defaults and binding keys #57379
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where
URL::defaults()
combined with route parameters (including model key binding fields) causes positional parameter misalignment when generating URLs withroute()
call.Problem:
When a route has a parameter in the URL, e.g.,
{workspace:uuid?}
, and its value is set viaURL::defaults()
(without using the route key), callingroute()
with positional parameters for other route parameters can incorrectly assign the first positional parameter to the prefix parameter. This results in an empty query string like?workspace=
instead of the intended URL.Reference: #56604
Solution:
Added the check for both named parameters and key binding fields.
Example: