[12.x] Http::batch - fix issue that non valid URL not triggering catch hook #57386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I was talking with @christophrumpel on X and he showed me that calling a non-valid URL was not triggering the
catch
hook of theHttp::batch
Fix
I saw that instead of a
\Illuminate\Http\Client\RequestException
in these cases it throws a\Illuminate\Http\Client\ConnectionException
, so I added this check, and also updated thecatch
hook to handle this