Use container to resolve PendingBatch and PendingChain for dispatch #57403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57402
The
Illuminate\Bus\Dispatcher
class initiate thePendingBatch
andPendingChain
instances directly, instead of using the container to resolve them.This makes impossible to extend and swap these classes.
Practical example:
->onQueue()
modifier for every instance of batches and chains, which can be unnecessarily verbose.PendingBatch
and/orPendingChain
instances, the dynamic queue resolution could be easily done in one place - inside the tenant awaredescendant class.