-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[12.x] Fix incorrect docblock #57507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And that's why just blindly changing something to |
I think the entire line was copied from See |
|
That may be so, but there sure is something passed in. With some effort, this can be done better than degrading it to |
|
The only two places where it is used—as a job as well, mind you—, framework/src/Illuminate/Queue/FailoverQueue.php Lines 127 to 151 in 570c154
framework/src/Illuminate/Queue/FailoverQueue.php Lines 80 to 103 in 570c154
Thank me later. |
|
Why? |
Description
The docblock referenced a
$jobparameter with types\Closure|string|object, but the constructor actually defines a$commandparameter of typemixed.This PR updates the docblock to reflect the constructor's parameters and types.
Note
$command.