Skip to content

Conversation

@faisuc
Copy link
Contributor

@faisuc faisuc commented Oct 23, 2025

Issue: #57455

Fix: file cache lock collision with identical keys

  • Prevents collisions between file cache entries and locks when using the same key.
  • Locks now use a separate directory by default, consistent with Redis/DB behavior.
  • Adds a test to verify Cache::remember() returns the cached value when a lock exists with the same key.

@NickSdot
Copy link
Contributor

Your LLM says it added a test but it didn't

@faisuc
Copy link
Contributor Author

faisuc commented Oct 23, 2025

I've now added the missing test on #57514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants