Modernize Flux usage #143
Open
Modernize Flux usage #143
+104
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as collapsible sidebars was changed in v2.3.0, you should also update the min-version in composer.json to ^2.3.0 |
Author
|
Good call, @hebbet - Ended up updating it to ^2.3.2 as 2.3.1 had a bug with the sidebar toggle. |
Awesomolocity
force-pushed
the
fix/update-deprecated-flux-usage
branch
from
39cc003 to
bda3660
Compare
Awesomolocity
temporarily deployed
to
Testing
GitHub Actions
Inactive
Awesomolocity
temporarily deployed
to
Testing
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flux UI has had some updates since this starter kit was written. Specifically, we've got some new elements, and some deprecated APIs. Within this PR, I seek to update the usage of Flux components, to make sure we're staying up to date with changes, while minimizing any visual or functional changes to existing starter kit layout.
A high level overview of the changes is as follows:
flux:brandcomponentstashableAPI onflux:sidebar, in favor of the newcollapsible="mobile"API.desktop-user-menu.blade.phpto remove around 30 lines of nearly identical code from the header and sidebar layoutsflux:navlistcomponents within the sidebar with the newerflux:sidebar.navcomponentsAgain, these changes should not significantly alter the functionality or design of the starter kit, but they do bring us more in line with the latest versions of Flux.