Add configurable vendor path and improve environment variable handling #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variables are accessible
This PR updates the `bootstrap` file to use `getenv()` instead of `$_ENV` when retrieving environment variables.
In some PHP configurations, `$_ENV` returns `null` unless the `variables_order` setting in `php.ini` includes the `E` flag. This can cause Octane to fail when resolving the application base path or vendor directory.
By switching to `getenv()`, Octane can reliably fetch environment variables without requiring users to modify their PHP configuration.
### Changes
- Replaced `$_ENV['APP_RUNNING_IN_CONSOLE']` with `getenv('APP_RUNNING_IN_CONSOLE')`.
- Ensured `COMPOSER_VENDOR_DIR` and other variables are resolved consistently.
### Why
When extending the Swoole server start process and attempting to change the vendor file path, `$_ENV` returned `null` unless `variables_order` was explicitly configured. This fix ensures smoother setup for developers across different environments.
### Impact
- No breaking changes.
- Improves reliability of environment variable handling in Swoole/Octane bootstrap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Octane bootstrap process and server start commands with better environment handling and support for custom vendor paths.
Changes
vendor_pathoption inconfig/octane.php:base_path('vendor').OCTANE_VENDOR_PATHenvironment variable.getenv()instead of$_ENV, ensuring environment variables are always available without requiring changes tophp.ini(variables_order).COMPOSER_VENDOR_DIRfromconfig('octane.vendor_path')to the environment.Why
$_ENVmay returnnullif PHP is not configured withEinvariables_order. Usinggetenv()avoids this issue.vendordirectory is not in the default location.COMPOSER_VENDOR_DIR.Impact