fix: Provide thread name for inspection #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
changed the title
keelerm84
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Thank you for this contribution! I will work on getting it released and folded into the SDK for you.
One thing I wanted to point out is that I did remove the host from the thread name. After some internal discussion, we have decided that isn't information we necessarily want to automatically inject.
keelerm84
pushed a commit
that referenced
this pull request
Mar 7, 2025
🤖 I have created a release *beep* *boop* --- ## [2.2.3](2.2.2...2.2.3) (2025-03-07) ### Bug Fixes * Provide thread name for inspection ([#46](#46)) ([191fd68](191fd68)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@keelerm84 Thanks for your quick response! Hot having a host name in the thread name is totally fine, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the client to assign a thread name that runs the stream. There is another PR launchdarkly/ruby-server-sdk#316 with a detailed explanation on why this is important. I believe this repository is maintained by the same team, so it would be great if you could take a look at it.