Skip to content

fix: Remove rake dependency from gemspec #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

fix: Remove rake dependency from gemspec #53

merged 1 commit into from
Apr 18, 2025

Conversation

@Exterm1nate
Copy link
Contributor

It breaks build from git repo in Docker

Ruby: 3.1.7

gem "ld-eventsource", git: "https://github.com/launchdarkly/ruby-eventsource", branch: "main"
#15 2.466 Fetching gem metadata from https://rubygems.org/........
#15 6.024 Fetching https://github.com/launchdarkly/ruby-eventsource
#15 7.026 
#15 7.026 [!] There was an error while loading `ld-eventsource.gemspec`: cannot load such file -- rake. Bundler cannot continue.
#15 7.026 
#15 7.026  #  from /usr/local/bundle/ruby/3.1.0/bundler/gems/ruby-eventsource-e58c181a039c/ld-eventsource.gemspec:6
#15 7.026  #  -------------------------------------------
#15 7.026  #  require "ld-eventsource/version"
#15 7.026  >  require "rake"
#15 7.026  #  
#15 7.026  #  -------------------------------------------
#15 ERROR: process "/bin/sh -c bundle install &&     rm -rf ~/.bundle/ \"${BUNDLE_PATH}\"/ruby/*/cache \"${BUNDLE_PATH}\"/ruby/*/bundler/gems/*/.git &&     bundle exec bootsnap precompile --gemfile" did not complete successfully: exit code: 14

There is no need for using rake, Dir.glob does the same job

@Exterm1nate Exterm1nate requested a review from a team as a code owner April 18, 2025 07:58
@keelerm84 keelerm84 changed the title feat: Remove rake dependency from gemspec fix: Remove rake dependency from gemspec Apr 18, 2025
@keelerm84 keelerm84 merged commit 8be0ccc into launchdarkly:main Apr 18, 2025
10 checks passed
@github-actions github-actions bot mentioned this pull request Apr 18, 2025
Merged
@keelerm84
Copy link
Member

Thank you for this contribution!

keelerm84 pushed a commit that referenced this pull request Apr 29, 2025
@github-actions
chore(main): release 2.2.4 (#55)
a74139b 
🤖 I have created a release *beep* *boop*
---


##
[2.2.4](2.2.3...2.2.4)
(2025-04-18)


### Bug Fixes

* Remove rake dependency from gemspec
([#53](#53))
([8be0ccc](8be0ccc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keelerm84 keelerm84 keelerm84 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Exterm1nate @keelerm84