Ensuring that poly<C, non_owning_storage, V> is trivially copyable.#57
Open
brevzin wants to merge 1 commit intoldionne:masterfrom
Open
Ensuring that poly<C, non_owning_storage, V> is trivially copyable.#57brevzin wants to merge 1 commit intoldionne:masterfrom
brevzin wants to merge 1 commit intoldionne:masterfrom
Conversation
Author
|
I... don't understand the failure, sorry. You're gonna have to give me a hint: |
|
Hi Barry, the build failure looks unrelated to this PR. This error is caused by calling I'm just here because this was the only search result for "error: read-only reference" "used as ‘asm’ output", so hopefully that helps someone else 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the boring boilerplate bullshit that makes it possible for
poly<C, non_owning_storage>to be trivially copyable - which is just a nice thing in certain contexts. There are more steps to take to improve this (i.e. there are several concepts that make no sense to type erase fornon_owning_storageand we can just remove them), so this is just the first go.