Refactor: Extract Arrow and Indicator components from Carousel #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extracts the arrow and indicator rendering logic from the main Carousel component into dedicated `Arrow` and `Indicator` components. - I created `src/components/Carousel/Arrow.tsx` for arrow controls. - I created `src/components/Carousel/Indicator.tsx` for indicator dots. - I updated `src/components/Carousel/index.tsx` to use these new components by modifying `defaultProps` for `renderArrowPrev`, `renderArrowNext`, and `renderIndicator`. This change improves code modularity, readability, and reusability of the arrow and indicator UI elements. All existing tests pass, and snapshots have been updated accordingly.
leandrowd
commented
May 26, 2025
package.json
Outdated
| "changelog": "auto-changelog --ignore-commit-pattern=\"(Merge pull request|Merge branch|Updating changelog|Prepare for publishing)\" --breaking-pattern \"BREAKING CHANGE:\"", | ||
| "update-codesandbox": "cd codesandbox/default && yarn add react-responsive-carousel@latest", | ||
| "format": "prettier \"**/*.{js,ts,tsx,json}\"", | ||
| "format": "prettier --write \"**/*.{js,ts,tsx,json}\"", |
There was a problem hiding this comment.
Please undo this change, we have format:write below for this
This commit extracts the arrow and indicator rendering logic from the main Carousel component into dedicated `Arrow` and `Indicator` components. - I created `src/components/Carousel/Arrow.tsx` for arrow controls. - I created `src/components/Carousel/Indicator.tsx` for indicator dots. - I updated `src/components/Carousel/index.tsx` to use these new components by modifying `defaultProps` for `renderArrowPrev`, `renderArrowNext`, and `renderIndicator`. - I reverted an unintentional modification to the `scripts.format` in `package.json` back to its original state. This change improves code modularity, readability, and reusability of the arrow and indicator UI elements. All existing tests pass, and snapshots have been updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extracts the arrow and indicator rendering logic from the main Carousel component into dedicated
ArrowandIndicatorcomponents.src/components/Carousel/Arrow.tsxfor arrow controls.src/components/Carousel/Indicator.tsxfor indicator dots.src/components/Carousel/index.tsxto use these new components by modifyingdefaultPropsforrenderArrowPrev,renderArrowNext, andrenderIndicator.This change improves code modularity, readability, and reusability of the arrow and indicator UI elements.
All existing tests pass, and snapshots have been updated accordingly.