-
Notifications
You must be signed in to change notification settings - Fork 127
feat: Add String.length_join and List.length_join
#779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
awaiting-review |
Std/Data/List/Lemmas.lean
Outdated
| -/ | ||
| import Std.Control.ForInStep.Lemmas | ||
| import Std.Data.List.Basic | ||
| import Std.Data.Nat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a cross cutting import, and also not a precise import. The needed theorem(s) should move to Std.Data.Nat.Init.Lemmas and that should be imported here. If you only need the definition then it can just be an import of Std.Data.Nat.Basic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to move the needed lemmas up into an Init folder, to reduce the imports needed here?
|
Note that Mathlib has https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/BigOperators/List/Basic.html#List.length_join stated in terms of a generic |
|
Given that mathlib already has a |
String.length_join and List.length_join
Quick fix for #770.