Skip to content

Conversation

@erdOne
Copy link
Member

@erdOne erdOne commented Nov 25, 2025


Open in Gitpod

@github-actions github-actions bot added the t-ring-theory Ring theory label Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

PR summary 1159dce834

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Polynomial.UniversalFactorizationRing 1504 1531 +27 (+1.80%)
M scripts/count-trans-deps.py
M scripts/count-trans-deps.py
M scripts/count-trans-deps.py
Import changes for all files
Files Import difference
Mathlib.RingTheory.Polynomial.UniversalFactorizationRing 27

Declarations diff

+ UniversalCoprimeFactorizationRing
+ UniversalCoprimeFactorizationRing.factor₁
+ UniversalCoprimeFactorizationRing.factor₁_mul_factor₂
+ UniversalCoprimeFactorizationRing.factor₂
+ UniversalCoprimeFactorizationRing.homEquiv
+ UniversalCoprimeFactorizationRing.homEquiv_comp_fst
+ UniversalCoprimeFactorizationRing.homEquiv_comp_snd
+ UniversalCoprimeFactorizationRing.isCoprime_factor₁_factor₂
+ UniversalFactorizationRing.jacobian_resentation
+ UniversalFactorizationRing.presentation
+ instance : Algebra.Etale R 𝓡' := by
+ isUnit_resultant_iff_isCoprime
+ resultant_eq_zero_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 28, 2025

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 28, 2025
@erdOne
Copy link
Member Author

erdOne commented Nov 29, 2025

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 29, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory): universal coprime factorization ring [Merged by Bors] - feat(RingTheory): universal coprime factorization ring Nov 29, 2025
@mathlib-bors mathlib-bors bot closed this Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants