-
Notifications
You must be signed in to change notification settings - Fork 907
[Merged by Bors] - feat(RingTheory): universal coprime factorization ring #32099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(RingTheory): universal coprime factorization ring #32099
Conversation
erdOne
commented
Nov 25, 2025
PR summary 1159dce834
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Polynomial.UniversalFactorizationRing | 1504 | 1531 | +27 (+1.80%) |
| M scripts/count-trans-deps.py | |||
| M scripts/count-trans-deps.py | |||
| M scripts/count-trans-deps.py |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Polynomial.UniversalFactorizationRing |
27 |
Declarations diff
+ UniversalCoprimeFactorizationRing
+ UniversalCoprimeFactorizationRing.factor₁
+ UniversalCoprimeFactorizationRing.factor₁_mul_factor₂
+ UniversalCoprimeFactorizationRing.factor₂
+ UniversalCoprimeFactorizationRing.homEquiv
+ UniversalCoprimeFactorizationRing.homEquiv_comp_fst
+ UniversalCoprimeFactorizationRing.homEquiv_comp_snd
+ UniversalCoprimeFactorizationRing.isCoprime_factor₁_factor₂
+ UniversalFactorizationRing.jacobian_resentation
+ UniversalFactorizationRing.presentation
+ instance : Algebra.Etale R 𝓡' := by
+ isUnit_resultant_iff_isCoprime
+ resultant_eq_zero_iff
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
jcommelin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
|
✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Johan Commelin <[email protected]>
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |