Skip to content

Conversation

@Thmoas-Guan
Copy link
Collaborator


Open in Gitpod

@Thmoas-Guan Thmoas-Guan added the easy < 20s of review time. See the lifecycle page for guidelines. label Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

PR summary 6a54a80825

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

++ isZero_iff_subsingleton
++ subsingleton_of_isZero

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Thmoas-Guan Thmoas-Guan changed the title add subsingleton of IsZero for AddCommGrpCat feat(Algebra): add subsingleton of IsZero for AddCommGrpCat Nov 25, 2025
@chrisflav chrisflav added awaiting-author A reviewer has asked the author a question or requested changes. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Nov 25, 2025
and remove the old one
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 25, 2025
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 25, 2025
Thmoas-Guan and others added 2 commits November 26, 2025 18:18
Co-authored-by: Christian Merten <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 26, 2025
Copy link
Collaborator

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer delegate

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 26, 2025
@jcommelin
Copy link
Member

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 26, 2025

✌️ Thmoas-Guan can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Nov 26, 2025
@Thmoas-Guan
Copy link
Collaborator Author

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 26, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra): add subsingleton of IsZero for AddCommGrpCat [Merged by Bors] - feat(Algebra): add subsingleton of IsZero for AddCommGrpCat Nov 26, 2025
@mathlib-bors mathlib-bors bot closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants