-
Notifications
You must be signed in to change notification settings - Fork 899
feat(RingTheory/AdjoinRoot): map #32111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(RingTheory/AdjoinRoot): map #32111
Conversation
And golf `algHomOfDvd`, `algHomOfAssociated` using it. From Toric Co-authored-by: Michał Mrugała <[email protected]>
PR summary 09610fd365Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| -- FIXME: Coercion hell | ||
| have : (RingHomClass.toRingHom <| (RingEquivClass.toRingEquiv f).symm).comp | ||
| (RingHomClass.toRingHom f) = .id _ := by ext; exact f.symm_apply_apply _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the plan on fixing this? What is the sequence of rewrites that ideally should closed this goal once we have the refactor done?
Co-authored-by: Andrew Yang <[email protected]>
And golf
algHomOfDvd,algHomOfAssociatedusing it.From Toric
Co-authored-by: Michał Mrugała [email protected]