Skip to content

Conversation

@YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Nov 25, 2025

And golf algHomOfDvd, algHomOfAssociated using it.

From Toric

Co-authored-by: Michał Mrugała [email protected]


Open in Gitpod

And golf `algHomOfDvd`, `algHomOfAssociated` using it.

From Toric

Co-authored-by: Michał Mrugała <[email protected]>
@YaelDillies YaelDillies added toric Part of the ongoing formalisation of toric varieties t-ring-theory Ring theory labels Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

PR summary 09610fd365

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ associated_map_map
+ coe_mapAlgEquiv
+ coe_mapAlgHom
+ coe_mapRingEquiv
+ map
+ mapAlgEquiv
+ mapAlgHom
+ mapAlgHom_comp_mapAlghom
+ mapRingEquiv
+ map_comp_map
+ map_of
+ map_root
+ ringHom_ext
+ symm_mapAlgEquiv
+ symm_mapRingEquiv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 26, 2025
@YaelDillies YaelDillies removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 26, 2025
Comment on lines +475 to +477
-- FIXME: Coercion hell
have : (RingHomClass.toRingHom <| (RingEquivClass.toRingEquiv f).symm).comp
(RingHomClass.toRingHom f) = .id _ := by ext; exact f.symm_apply_apply _
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the plan on fixing this? What is the sequence of rewrites that ideally should closed this goal once we have the refactor done?

Co-authored-by: Andrew Yang <[email protected]>
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-ring-theory Ring theory toric Part of the ongoing formalisation of toric varieties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants