feat: add pretty printer flag to instantiate non-ground delayed assignments#12393
Open
feat: add pretty printer flag to instantiate non-ground delayed assignments#12393
Conversation
e69e3c7 to
170222b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an opt-in pretty printing flag
pp.mvars.delayedNonGroundthat takes effect whenpp.mvars.delayedis false.Recall that
instantiateMVarsdoes not instantiate a delayed assigned MVar if the assignment is non-ground (i.e., contains metavariables itself). This flag opts into doing the instantiation while pretty printing. Example:This flag is most useful for debugging metaprograms that create synthetic opaque metavariables and assign those to non-ground solutions. It happens regularly that incomplete instantiation leads debugging sessions down the wrong path.