feat: add bitblasting circuit for BitVec.cpop#12433
Draft
luisacicolini wants to merge 125 commits intoleanprover:masterfrom
Draft
feat: add bitblasting circuit for BitVec.cpop#12433luisacicolini wants to merge 125 commits intoleanprover:masterfrom
BitVec.cpop#12433luisacicolini wants to merge 125 commits intoleanprover:masterfrom
Conversation
Contributor
Author
|
changelog-library |
luisacicolini
commented
Feb 11, 2026
luisacicolini
commented
Feb 11, 2026
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
luisacicolini
commented
Feb 13, 2026
bollu
reviewed
Feb 13, 2026
Contributor
bollu
left a comment
There was a problem hiding this comment.
I did a full pass. I've checked for nonterminal simps, naming conventions, and I've asked to move all the casts that occur in the theorem statements to become hypotheses with default arguments (it makes the theorem statement much more sane to read).
src/Std/Tactic/BVDecide/Bitblast/BVExpr/Circuit/Lemmas/Operations/Cpop.lean
Outdated
Show resolved
Hide resolved
src/Std/Tactic/BVDecide/Bitblast/BVExpr/Circuit/Impl/Operations/Cpop.lean
Outdated
Show resolved
Hide resolved
src/Std/Tactic/BVDecide/Bitblast/BVExpr/Circuit/Impl/Operations/Cpop.lean
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a bitblasting circuit for
BitVec.cpop.