refactor: remove Subarray.foldl and other slice operation aliases#12441
Open
datokrat wants to merge 2 commits intonightly-with-manualfrom
Open
refactor: remove Subarray.foldl and other slice operation aliases#12441datokrat wants to merge 2 commits intonightly-with-manualfrom
datokrat wants to merge 2 commits intonightly-with-manualfrom
Conversation
|
Mathlib CI status (docs):
|
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Feb 11, 2026
Collaborator
|
Reference manual CI status:
|
Contributor
Author
|
@david-christiansen Given that we can now use At least my experience of resolving breakage inside Lean was quite nice; I was able to resolve the problems by clicking on the hints in the error messages. |
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
Subarray.foldl(M),Subarray.toArrayandSubarray.sizein favor of theStd.Slice-namespaced operations. Dot notation will continue to work. If, say,Subarray.sizeis explicitly referred to, an error suggesting to useStd.Slice.sizewill show up.