chore: refactor match elaborator to be used from the do elaborator#12451
Open
chore: refactor match elaborator to be used from the do elaborator#12451
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for 9a89539 against 818a0ec are in! @sgraf812
Small changes (1✅, 3🟥)
|
9a89539 to
2518e00
Compare
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
2518e00 to
06e8a5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the necessary hooks for the new do elaborator to call into the let and match elaborator.
The
do matchelaborator needs access to a couple of functions from the termmatchelaborator to implement its ownelabMatchAlt. In particular,withEqs,withPatternVarsandcheckNumPatternsneed to be exposed. Furthermore, I think it makes sense to shareinstantiateAltLHSs.